Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 2 years ago

#8685 closed defect (bug) (worksforme)

Minified js and css not available

Reported by: josh401's profile josh401 Owned by:
Milestone: Priority: normal
Severity: normal Version: 10.0.0
Component: Core Keywords:
Cc:

Description

In bp-members/classes/class-bp-members/admin.php, line 682, enqueue_scripts function
On 688, I am returning .min.
So the bp_core_get_minified_asset_suffix function is returning .min.

When this is used on lines 689 and 709, it is returning the assets as 'admin.min.css' and 'admin.min.js'; respectively.

But in the bp-members/admin/js folder, there is not an admin.min.js file. Only an admin.js file.

Similarly, in the bp-members/admin/css folder, there is not an admin.min.css file. Only an admin.css file.

I noticed this when I was in the admin panel, editing an extended profile field for a user, and I was unable to change the "visible by" field. Clicking it did not open the dropdown. I inspected the console and noticed the two minified files were coming back as 404.

I don't know if BP is to provide these resources by default; or if something on my end is preventing them from populating dynamically?

Thankfully, BP provides awesome filters, and in the meantime I am able to filter the two resources, and string replace the .min from both.

Change History (2)

#1 @josh401
2 years ago

I'm sorry, but this was my fault. I guess I learn something new every day.
I learned my team is pulling Buddypress from Github; instead of the plugin download from WordPress.
I just downloaded the plugin from WordPress; and the .min files are indeed present.

My team explained to me the reason the .min files are not included in the github repository, is because it is normal practice to minify these files during the build process.

So, it was me. And it is something we should do on our end.

#2 @imath
2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Ok, no worries 😉

Note: See TracTickets for help on using tickets.