Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 2 years ago

#8648 closed defect (bug) (fixed)

Not showning current selected compose submenu in message page.

Reported by: devanshijoshi's profile devanshijoshi Owned by: imath's profile imath
Milestone: 10.2.0 Priority: normal
Severity: normal Version: 10.0.0
Component: Templates Keywords: has-patch
Cc: message

Description

On the message page, When going to compose sub-menu it does not show that the compose menu is selected as other sub-menus do.

The above image shows that the compose menu is open but still the color of the compose sub-menu is not changed.
https://prnt.sc/u1fOWwVPhRkL

Tested in twenty-twenty, twenty-twenty-one, twenty-twenty-two, foodmania, inspirebook and rtdating themes.
tested in PHP version: 8.1.3
buddypress version: 10.0.0 & 10.0.1

Attachments (1)

8648.patch (1.7 KB) - added by imath 3 years ago.

Download all attachments as: .zip

Change History (5)

#1 @imath
3 years ago

  • Component changed from Messages to Templates
  • Milestone changed from Awaiting Review to 10.2.0
  • Owner set to imath
  • Status changed from new to assigned

Hi thanks @devanshijoshi for your feedback. I’ll look at it asap

@imath
3 years ago

#2 @imath
3 years ago

  • Keywords has-patch added; needs-patch removed

The above patch should fix the issue. I'll run some complementary tests to be 💯 sure!

#3 @imath
2 years ago

In 13259:

BP Nouveau: highlight the Messages UI compose nav when clicked

This nav was only set as current when the compose URL was loaded. As soon as the screen display was managed using JavaScript, it wasn't highlighted/set as current when clicked. This commit makes sure it's now the case.

Props devanshijoshi

See #8648 (trunk)

#4 @imath
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13260:

BP Nouveau: highlight the Messages UI compose nav when clicked

This nav was only set as current when the compose URL was loaded. As soon as the screen display was managed using JavaScript, it wasn't highlighted/set as current when clicked. This commit makes sure it's now the case.

Props devanshijoshi

Fixes #8648 (branch 10.0)

Note: See TracTickets for help on using tickets.