Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#8645 closed defect (bug) (fixed)

Provide context to the `bp_is_user_spammer` filter

Reported by: dd32's profile dd32 Owned by: imath's profile imath
Milestone: 10.2.0 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch
Cc:

Description

The bp_is_user_spammer() functions filter bp_is_user_spammer filter only passes the result of the function through it, but doesn't pass the actual $user or $user_ID of which the filter is acting upon.

Change History (9)

#2 @imath
3 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 10.2.0

Hi @dd32

Thanks a lot for your suggestion, we’ll add it in next minor version. Too bad our Trac doesn’t have the same feature the WordPress one has to support PRs on GitHub 😉.

#3 @dd32
3 years ago

Too bad our Trac doesn’t have the same feature the WordPress one has to support PRs on GitHub 😉.

When someone adds me to the BuddyPress organisation as an owner so I can set it up, I shall ;)

#4 @imath
3 years ago

Awesome thanks a lot @dd32 I’m asking it to JJJ 👍

#6 @imath
3 years ago

In 13254:

Add a GitHub template for pull requests

Pull Requests made on the BuddyPress GitHub repository are only used for code reviews and must be linked to a BuddyPress trac ticket. This template explains this fact and provides the contributor some guides.

Props dd32

See #8645

#7 @imath
3 years ago

In 13255:

Provide context to bp_is_user_spammer & bp_is_user_deleted filters

These two filters now include a second parameter to pass the WP_User object.

Props dd32

See #8645 (trunk)

#8 @imath
3 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13256:

Provide context to bp_is_user_spammer & bp_is_user_deleted filters

These two filters now include a second parameter to pass the WP_User object.

Props dd32

Fixes #8645 (branch 10.0)

#9 @imath
3 years ago

In 13258:

Edit the GitHub pull requests template

Fix a missing "WordPress/BuddyPress" replacement about the inline comment informing where to paste the BuddyPress trac ticket link.

See #8645

Note: See TracTickets for help on using tickets.