Support .webp images for profile photos or cover images

[imath]

This ​bad review contains a suggestion about supporting webp images. I believe we should include the support of it for profile photos and cover images.

[imath]

NB: WordPress supports WebP since version 5.8, the patch needs to be updated to include a WP version check.

[imath]

The above patch is adding some bp_is_running_wp( '5.8.0', '>=' ) to make sure BuddyPress profile image / cover image can use .webp images.

[dcavins]

This works well. I tried it with WP 5.7 and the current 6-alpha, and the behavior was as expected in both cases. I was sort of surprised when WP was able to edit a WebP. :)

I do sort of wish that instead of listing out the allowed types in bp_attachments_get_allowed_types(), we could fetch them from BP_Attachment->get_supported_image_types() so that they'd only be managed in one location.

Thanks for this update!

[imath]

Thanks for you feedback @dcavins It helped me found some issues I've missed on the 2 first patches. Due to "historical filters" about the avatar object, it's easier to manage allowed file types from bp_attachments_get_allowed_types(), that's why I've removed BP_Attachment->get_supported_image_types() instead of your suggestion.

[imath]

In 13315:

Media: add support for the .webp image file type

NB: this support will only be available when the community site uses WP >= 5.8.

Props dcavins

Fixes #8643

[imath]

Ouch! I forgot to take in account the fact this support is only available in WP >= 5.8 in unit tests, that's why our it failed here: ​https://github.com/buddypress/buddypress/runs/7819196650

[imath]

In 13316:

Media: adjust avatar/cover image unit tests for the WP v5.7 context

As the .webp image file type will only be available if WP version >= 5.8, we need to only check for it using the same requirement.

Fixes #8643