Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

#8596 closed enhancement (fixed)

Update `BP_Activity_Activity::get_id()` function parameters as optional

Reported by: oztaser's profile oztaser Owned by: imath's profile imath
Milestone: 10.0.0 Priority: normal
Severity: normal Version:
Component: Activity Keywords: has-patch
Cc:

Description

Passing arguments as an array more useful and make them optional.

Attachments (2)

8596.patch​ (5.9 KB) - added by oztaser 3 years ago.
8596.2.patch​ (6.6 KB) - added by oztaser 3 years ago.

Download all attachments as: .zip

Change History (5)

@oztaser
3 years ago

#1 @imath
3 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 10.0.0

Hi @oztaser

Interesting improvement 👍. But we need to make sure developer not using the new array can still use the function. Have a look at BP_Activity_Activity::get() to see how we did in such a case 😉

@oztaser
3 years ago

#2 @oztaser
3 years ago

  • Keywords has-patch added; needs-refresh removed

Hi @imath,

Thanks for your feedback, good catch. I've updated my patch for adding backward compatibility.

#3 @imath
3 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13150:

Group the BP_Activity_Activity::get_id() method params into an array

Deprecate old arguments and add backward compatibility for users still using these.

Props oztaser

Fixes #8596

Note: See TracTickets for help on using tickets.