Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#8586 closed defect (bug) (fixed)

Extra double quote inside a tag of the xProfile Admin

Reported by: josett225's profile josett225 Owned by: imath's profile imath
Milestone: 9.2.0 Priority: normal
Severity: normal Version: 8.0.0
Component: Extended Profile Keywords: has-patch commit
Cc:

Description

This is a follow-up to #8483.

Hi there, not sure this has been fixed as I found 2 errors in the code of bp-xprofile-admin.php version 9.9.1 . A double quote ending the id="tabs-signup-group" ans still the </a> issue.

<div id="tabs-signup-group"" class="tab-wrapper">

<div class="tab-toolbar">

<p class="description"><?php esc_html_e( 'Drag fields from other groups and drop them on the above tab to include them into your registration form.', 'buddypress' ); ?></a>

Attachments (1)

8586.patch (735 bytes) - added by imath 3 years ago.

Download all attachments as: .zip

Change History (6)

#1 @imath
3 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 9.2.0
  • Owner set to imath
  • Status changed from new to assigned
  • Version set to 8.0.0

Hi @josett225

Thanks a lot for your feedback. I agree about the double quote : I'll fix it asap.

But if you look at the code of our development version (trunk) and of the 9.1.1 tag, the wrong use of </a> instead of </p> has been fixed in [12968].

trunk

https://buddypress.trac.wordpress.org/browser/trunk/src/bp-xprofile/bp-xprofile-admin.php#L312

9.1.1

https://buddypress.trac.wordpress.org/browser/tags/9.1.1/src/bp-xprofile/bp-xprofile-admin.php#L312

@imath
3 years ago

#2 @imath
3 years ago

  • Keywords has-patch commit added; needs-patch removed

#3 @imath
3 years ago

In 13126:

Admin: drop an extra double quote inside the #tabs-signup-group tag

Props josett225

See #8586 (trunk)

#4 @imath
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13127:

Admin: drop an extra double quote inside the #tabs-signup-group tag

Props josett225

Fixes #8586 (9.0 branch)

#5 @imath
2 years ago

  • Summary changed from 2 errors found in to Extra double quote inside a tag of the xProfile Admin
Note: See TracTickets for help on using tickets.