Skip to:
Content

BuddyPress.org

Opened 4 months ago

Closed 4 months ago

#8577 closed defect (bug) (fixed)

Inaccurate error message on Group Invites page

Reported by: comminski Owned by: imath
Milestone: 10.0.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: needs-patch
Cc:

Description

Hi, I think there is an inaccurate message in the Group Invites plugin. Here's the issue:

  1. Log in and friend another user
  2. Create a group
  3. Go to the group, click the 'send invites' tab and then click the 'Friendships' tab
  4. Enter a random search term (one that will return no results)

Expected result:

I expected to see A message saying that no members were found

Actual result:

The following message All your friends are already members of this group, or have already received an invite to join this group, or have requested to join it.


I don't think this message is correct as the friend has not been invited and and is not a group member.

I think the problem seems to be with the logic on line 320 of the 'ajax.php' (/buddypress/bp-templates/bp-nouveau/includes/groups/ajax.php) in the method 'bp_nouveau_ajax_get_users_to_invite'

It looks like the 'No Members Found' error message will always be overwritten by the other message if the scope is 'friends'.

Attachments (2)

Screenshot at 2021-09-27 12-34-55.png (46.6 KB) - added by comminski 4 months ago.
Screenshot at 2021-09-27 12-35-16.png (55.0 KB) - added by comminski 4 months ago.

Download all attachments as: .zip

Change History (4)

#1 @imath
4 months ago

  • Component changed from Groups to Templates
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 10.0.0
  • Version changed from 9.1.1 to 3.0.0

Good catch @comminski I'll work on a fix asap!

#2 @imath
4 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13115:

Improve BP Nouveau Group Invites UI feedback message content & style

  • Create a more accurate message when no friends matched a search although the users do have friends.
  • Use the Ajax response specific type if set to display the right feedback style.

Props comminski

Fixes #8577

Note: See TracTickets for help on using tickets.