Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 2 weeks ago

#8552 closed enhancement (fixed)

Add cache flag to Query Classes

Reported by: espellcaste's profile espellcaste Owned by: espellcaste's profile espellcaste
Milestone: 15.0.0 Priority: low
Severity: normal Version: 9.0.0
Component: Performance Keywords: has-patch has-unit-tests
Cc:

Description

Placeholder ticket for an investigation to adding cache flags to BuddyPress component Query Classes.

See: https://developer.wordpress.org/reference/classes/wp_query/#caching-parameters

Ideally, a 'cache_results' => false would be passed as an argument and the query would not be cached.

Change History (26)

#1 @imath
3 years ago

  • Milestone changed from 10.0.0 to Up Next

We won't have time to work on these during 10.0.0, sorry about it.

#2 @imath
20 months ago

  • Milestone changed from Up Next to 12.0.0

#3 @espellcaste
19 months ago

  • Milestone changed from 12.0.0 to Awaiting Contributions
  • Owner espellcaste deleted

This ticket was mentioned in Slack in #buddypress by espellcaste. View the logs.


6 months ago

#5 @espellcaste
6 months ago

  • Milestone changed from Awaiting Contributions to Up Next
  • Owner set to espellcaste

#6 @imath
2 months ago

  • Milestone changed from Up Next to 15.0.0

This ticket was mentioned in PR #342 on buddypress/buddypress by renatonascalves.


7 weeks ago
#7

  • Keywords has-patch has-unit-tests added; needs-patch needs-unit-tests removed

@imath commented on PR #346:


7 weeks ago
#12

Hi @renatonascalves

Thanks for your work on this, I assigned @dcavins as the reviewer: I believe as he worked on the feature in the first place, he's the best of us to review your changes.

renatonascalves commented on PR #344:


7 weeks ago
#13

@imath 🤔 Could you elaborate what you mean? This pr is not about registering the cache group. But avoiding the data to be added to cache when querying with ::get.

renatonascalves commented on PR #345:


7 weeks ago
#14

@imath 🤔 Could you elaborate what you mean? This pr is not about registering the cache group. But avoiding the data to be added to cache when querying with ::get.

#17 @espellcaste
6 weeks ago

In 13987:

Groups: Add cache_results flag to the BP_Groups_Group::get getter.

When performing a request with cache_results, it stops the group information retrieved from being added to the cache.

See #8552
Closes https://github.com/buddypress/buddypress/pull/342/

#18 @espellcaste
6 weeks ago

In 13988:

Activity: Add cache_results flag to the BP_Activity_Activity::get getter.

When performing a request with cache_results, it stops the activity information retrieved from being added to the cache.

See #8552
Closes https://github.com/buddypress/buddypress/pull/343/

#19 @espellcaste
6 weeks ago

In 13989:

Members: Add cache_results flag to the BP_Signup::get getter.

When performing a request with cache_results, it stops the signup information retrieved from being added to the cache.

See #8552
Closes https://github.com/buddypress/buddypress/pull/345/

#20 @espellcaste
6 weeks ago

In 13990:

Core: Add cache_results flag to the BP_Invitation::get getter.

When performing a request with cache_results, it stops the invite information retrieved from being added to the cache.

See #8552
Closes https://github.com/buddypress/buddypress/pull/346/

#21 @espellcaste
6 weeks ago

In 13991:

Core: Add cache_results flag to the BP_Optout::get getter.

When performing a request with cache_results, it stops the optout information retrieved from being added to the cache.

See #8552
Closes https://github.com/buddypress/buddypress/pull/344/

#23 @espellcaste
5 weeks ago

In 14000:

XProfile: Add cache_results flag to the BP_XProfile_Group::get getter.

When performing a request with cache_results, it stops the XProfile group information retrieved from being added to the cache.

Props imath.

See #8552
Closes https://github.com/buddypress/buddypress/pull/357

#24 @espellcaste
3 weeks ago

  • Priority changed from normal to low

#25 @espellcaste
3 weeks ago

Just need to confirm if I forgot to add support for any class.

#26 @espellcaste
2 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Looks like I got all the currently ::get getters with support for the object cache.

Note: See TracTickets for help on using tickets.