PHP Fatal when enabling friends component

[dcavins]

When enabling the friends component from wp-admin/admin.php?page=bp-components, this error is returned:

Fatal error: Uncaught Error: Call to undefined function bp_get_friends_slug() in /Users/cavinsd/Local Sites/bptest/app/public/wp-content/plugins/buddypress/bp-core/bp-core-template.php on line 2414

[dcavins]

Same is true when enabling groups:
Fatal error: Uncaught Error: Call to undefined function bp_get_groups_slug() in /Users/cavinsd/Local Sites/bptest/app/public/wp-content/plugins/buddypress/bp-core/bp-core-template.php on line 2442

I'm assuming this is because code for the friends and groups components are not loaded when the component is not active. I hate to use function_exists() for something like this, but I'll attach a basic patch.

[dcavins]

Avoid fatals when enabling friends and groups components.

[imath]

Nothing has changed there lately, this is really weird.

[imath]

Milestone renamed

[imath]

@dcavins could you share the complete trace for this error, because the function is only used in front-end context (see bp_get_the_body_class()), I'm very surprised WP's body_class() would be used in Admin 🤔

[dcavins]

Ah, this error is caused by having the "Query Monitor" plugin activated on my installation:
bp_is_user_friends_activity()
wp-content/plugins/query-monitor/collectors/conditionals.php:88

It does seem like the functions should be prevented from being called when they don't exist, though, so maybe QM just found a curiosity for us.

[imath]

As we are using a lot bp_is_active( $component ), we could add a check inside it to make sure the component is fully loaded. Because if we need to check if a function exists each time, bp_is_active( $component_id ) is useless 😬. Maybe you can test adding this into the bp_is_active() function to see if it fixes the issue?

if ( ! did_action( 'bp_' . $component . '_includes' ) ) {
   return false;
}

PS: there might be problem with PHP Unit tests with this though...

[imath]

@dcavins what do you think? Can we consider this as a very rare edge case and close the ticket? Or is a fix needed?

[dcavins]

Seems ok to me to declare it an edge case. Thanks!