Skip to:
Content

BuddyPress.org

Opened 2 months ago

Last modified 3 weeks ago

#8550 assigned defect (bug)

"Invitations" tab visible to users when they're not able to send invitations.

Reported by: niftythree Owned by: dcavins
Milestone: 10.0.0 Priority: normal
Severity: normal Version: 1.0
Component: Groups Keywords: 2nd-opinion
Cc:

Description

Hello,

We’ve noticed a bit of a quirk in BuddyPress. When the “Friend Connections” component is turned off, but the “User Groups” component is still turned on, users will still see the “Invitations” tab under groups in their own profiles, even though no user can send them an invitation to a group.

We’ve done some testing and can’t work out an obvious reason why this tab would still be visible/available to users when it’s not possible to send invitations to other users.

We're running BuddyPress version 9, and occurs when all other plugins are deactivated and a default theme is used.

Thanks.

Change History (7)

#1 @imath
2 months ago

  • Keywords reporter-feedback added

Hi,

if you're using the BP Nouveau template pack, it's a feature 😉. This template pack comes with a Group Invites UI allowing users to invite any other to join their group. If you want to disable it you can use:

add_filter( 'bp_nouveau_groups_disallow_all_members_invites', '__return_true' );

https://cldup.com/3wsn9GB40d.png

Are you using the BP Nouveau template pack (see Settings > BuddyPress > Options)?

#2 @niftythree
2 months ago

Hi @imath,

Thanks for getting back to us so quickly! :)

We're using the BP Legacy template pack; regardless, we thought we'd try the code anyway, but the "Invitations" tab was still visible.

Thanks.

#3 @niftythree
2 months ago

  • Keywords reporter-feedback removed

#4 @imath
4 weeks ago

  • Keywords 2nd-opinion added
  • Milestone changed from Awaiting Review to 10.0.0
  • Version changed from 9.0.0 to 1.0

Thanks for your feedback @niftythree I now fully understand the issue. I agree we should improve this part of the Groups invite feature.

Historically Groups invite required the Friends component to be active. BP Nouveau added an exception to this allowing members to invite any others.

If we use BP Legacy having the friends component inactive:

  • The single Group invite nav is not showing ✅
  • The Group settings create screen as well as the Group manage screen are showing a setting to let the Group creator choose which Group roles can invite people ❌
  • The single Member's Pending invites nav is showing (what you reported) ❌

If we use BP Nouveau it's not possible to disable the Groups Invite feature even if we do add_filter( 'bp_nouveau_groups_disallow_all_members_invites', '__return_true' );
Using this filter is only making an effect when the friends component is active.

We should fix red crosses 🤔. @dcavins I'd like to have your opinion about it. What do you think?

Last edited 4 weeks ago by imath (previous) (diff)

#5 @niftythree
4 weeks ago

Hi @imath

Thanks for the update and all of the information; that really helps us to understand the context. 😊

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


3 weeks ago

#7 @dcavins
3 weeks ago

  • Owner set to dcavins
  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.