Opened 3 years ago
Closed 3 years ago
#8549 closed feature request (worksforme)
Missing Hook in Settings Tab
Reported by: | comminski | Owned by: | imath |
---|---|---|---|
Milestone: | Priority: | low | |
Severity: | minor | Version: | 3.0.0 |
Component: | Groups | Keywords: | reporter-feedback |
Cc: |
Description
Every settings page has a bp_nouveau_member_hook( 'before', 'settings_template' );
and bp_nouveau_member_hook( 'after', 'settings_template' );
hook that wraps the template. However the Group Invites template does not have these hooks. ('/buddypress/members/single/settings/group-invites.php').
Is there a reason this template does not have these hooks, and if not, would it be possible to add them?
Change History (4)
#1
@
3 years ago
- Component changed from Members to Groups
- Milestone changed from Awaiting Review to 10.0.0
- Owner set to imath
- Version changed from 9.0.0 to 3.0.0
#2
@
3 years ago
- Keywords reporter-feedback added
I got it, that's because these hooks are included into the bp_nouveau_group_invites_interface()
function. You can use them, here they are: 'bp_before_group_send_invites_content'
& 'bp_after_group_send_invites_content'
.
I believe we can close this ticket, what do you think?
#3
@
3 years ago
Thanks a lot for looking into this. Unfortunately, although the 'bp_before_group_send_invites_content' hook does fire within the group settings page, it does not fire within the profile settings page.
Also, within the group, it fires before the secondary menu. Where the 'bp_before_member_settings_template' fires after that menu.
What I wanted to do was to add a HTML Wrapper to all the Profile Settings pages, which I could do with the 'bp_before_member_settings_template' and 'bp_after_member_settings_template' for all the profile settings pages except the new Group Invites page.
Here are a few screenshots that show what I was trying to do. The elements in red are where I was trying to wrap the content with a div.
https://drive.google.com/file/d/1uDLAvSCzNgyimBDWxE4recrV4Dtx0trm/view?usp=sharing
https://drive.google.com/file/d/1KQjQDLXqIVMRd01VFAN_vwWJ1IgOY7n1/view?usp=sharing
https://drive.google.com/file/d/1ml6Xz1Ba7I4HkhSsAurAGC-wFz2moH5U/view?usp=sharing
It's a very minor issue, so no worries if you think its best to close the issue.
Hi, thanks for your report, the Group Invite UI mainly use JavaScript templates that’s probably the reason why. I agree we should at least provide « Legacy » hooks. I’ll look at it asap.