Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#8530 closed defect (bug) (fixed)

2 RTL CSS files have not been generated during the process

Reported by: imath Owned by: netweb
Priority: normal Milestone: 9.0.0
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch commit
Cc:

Description

I don't think I missed something. I just ran some tests and find out although CSS files are modified for online-members.css and active-members.css, the rtlcss grunt task keeps on skipping the files. The result of the task for these two files looks like:

Skip saving unmodified file src/bp-members/css/blocks/active-members.css.
Skip saving unmodified file src/bp-members/css/blocks/online-members.css.

I suggest to set the task option saveUnmodified to true to fix the issue.

Attachments (2)

8530.patch​ (1.1 KB ) - added by imath 5 years ago.
8530.2.patch​ (4.5 KB ) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (4)

@imath
5 years ago

@imath
5 years ago

#1 @imath
5 years ago

  • Keywords commit added; 2nd-opinion removed

Well actually, now I had another look to it: it seems too bad to load 2 stylesheets when CSS rules are common to both blocks 😁.

#2 @imath
5 years ago

  • Resolution → fixed
  • Status new → closed

In 13021:

Use the same editor stylesheet for Online & Active members blocks

These two blocks are outputing Member avatars the same way. Instead of having two CSS files (one for each block), let's use a common stylesheet for both.

This commit also edit the rtlcss grunt task to make sure the RTL version of this common stylesheet is generated.

Fixes #8530

Note: See TracTickets for help on using tickets.