PHP8 multi-byte safety warning

[ionvv]

When using BP 8.0.0 with PHP8 and calling bp_xprofile_get_hidden_fields_for_user( $user->ID ) a warning will be raised: Warning: Only the first byte will be assigned to the string offset in /var/www/html/domain.tld/wp-content/plugins/buddypress/bp-xprofile/bp-xprofile-functions.php #1315

[imath]

Thanks a lot for your report. We’ll check this issue asap.

[johnjamesjacoby]

Cast results of bp_get_user_meta() to array

[johnjamesjacoby]

Cast to array early. Remove late array casting.

[vapvarun]

I have also noticed this issue earlier ​https://buddypress.org/support/topic/buddypress-8-0-0-release-candidate/#post-319037

[imath]

Thanks a lot @johnjamesjacoby for the patch and sorry @vapvarun i missed it earlier. I'm going to test it asap.

[imath]

In 13011:

Avoid a PHP8 warning when xProfile user visibility levels are empty

When the record does not exist yet into the usermeta table, getting the 'bp_xprofile_visibility_levels' usermeta returns an empty string while we're expecting an array. As we use the expected array to reset the visibility level if the administrator enforced a specific visibility to the field, it's causing the PHP8 warning. To fix it, we are now casting the 'bp_xprofile_visibility_levels' usermeta as soon as we get it.

Props johnjamesjacoby

See #8503 (branch 8.0)

[imath]

In 13012:

Avoid a PHP8 warning when xProfile user visibility levels are empty

When the record does not exist yet into the usermeta table, getting the 'bp_xprofile_visibility_levels' usermeta returns an empty string while we're expecting an array. As we use the expected array to reset the visibility level if the administrator enforced a specific visibility to the field, it's causing the PHP8 warning. To fix it, we are now casting the 'bp_xprofile_visibility_levels' usermeta as soon as we get it.

Props johnjamesjacoby

Fixes #8503 (trunk)

[imath]

Ticket retargeted after milestone deleted