Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#849 closed defect (bug) (no action required)

Extra closing div in bphome/comments.php

Reported by: agentmaximus's profile agentmaximus Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 1.1 Priority: major
Severity: Version:
Component: Keywords:
Cc: nicolagreco

Description

There is an extra closing div in bphome/comments.php at line 68 of revision 1473.

There does not appear to be an opening div that is depends on the same condition being true.

<?php if ( $user_ID ) : ?>
</div>
<?php endif; ?>

Change History (6)

#1 @apeatling
13 years ago

  • Milestone set to 1.0.4

I believe this is there for a reason, can someone else confirm this?

#2 @johnjamesjacoby
13 years ago

  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

This goes way back to the comments turned off/not logged in situation from a few months back. I believe this was Nicola's fix that ended up not actually being a fix, but never got re-addressed.

I'll check it today.

#3 @nicolagreco
13 years ago

  • Cc nicolagreco added

the bphome is now included in bp-sn-framework, and for what i now, that's fixed, can you update to latest trunk and notice us?

#4 @apeatling
13 years ago

  • Milestone changed from 1.0.4 to 1.1

Milestone 1.0.4 deleted

#5 @apeatling
13 years ago

  • Resolution set to invalid
  • Status changed from assigned to closed

#6 @apeatling
13 years ago

This theme is deprecated now, please use the default.

Note: See TracTickets for help on using tickets.