Skip to:
Content

BuddyPress.org

Opened 4 months ago

Closed 4 months ago

#8473 closed defect (bug) (fixed)

Unscoped bp_nouveau_ajax_querystring on single activity page is affecting other loops

Reported by: sbrajesh Owned by: imath
Milestone: 8.0.0 Priority: normal
Severity: normal Version: 7.3.0
Component: Core Keywords: has-patch
Cc: sbrajesh

Description

Hi,
The function bp_nouveau_ajax_querystring which filters on 'bp_ajax_querystring' has a part of code like this

	// Single activity.
	if ( bp_is_single_activity() ) {
		$qs = array(
			'display_comments=threaded',
			'show_hidden=true',
			'include=' . bp_current_action(),
		);
	}

Since it does not check the $object for activity type, It is affecting all other loops on the single activity page. I have a theme with sidebar for single activity page and the members loop is getting affected(include=activityid)

If we update the code and add test for object type, that will fix the issue. Please find the patch attached.

Attachments (1)

8473.diff​ (485 bytes) - added by sbrajesh 4 months ago.

Download all attachments as: .zip

Change History (4)

@sbrajesh
4 months ago

#1 @imath
4 months ago

  • Milestone changed from Awaiting Review to 8.0.0

Patch looks good! Thanks for your contribution 👌. We’ll have it fixed asap.

#2 @sbrajesh
4 months ago

Thank you.

#3 @imath
4 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12947:

Nouveau: improve the single Activity screen Ajax querystring override

To avoid interfering with other objects loop on this screen, we need to make sure the Ajax querystring is about the activity object before overriding it.

Props sbrajesh

Fixes #8473

Note: See TracTickets for help on using tickets.