bp_core_clear_cache should be filterable

[shawfactor]

Right now bp_core_clear_cache just calls prune_super_cache( $cache_path, true );

This has two major problems, namely

1. it is complete overkill (especially on multisite) as this clears the entire wp super cache cache.

2. This just relies on wp super cache, if the code stays it should be a general solution

There ae two solutions. Either remove the code entirely (probably the best one)

or

Change the code such you can filter the circumstances in which you want to delete the cache. And maybe change the caching mechanism through a filter.

[shawfactor]

Hello can someone look at this? All that is needed is a simple filter to turn this function off. As the way it clears the cache can be very heavy handed.

[espellcaste]

Let's discuss this further in the next milestone. The solution seems simple but I'd like to better understand the use case and the possible side effects of introducing a new hook.

[shawfactor]

Ideally we should get rid of wp super cache support from buddypres entirely (it is plugin territory). But at a minimum the ability to selectively suppress the caching behaviour is needed as buddypres removes all wpsc caches every time something changes in buddypress.

This is complete overkill.

[imath]

Hi, sorry this ticket is postponed once again. I haven't seen it soon enough 😞. I believe as BuddyPress is used to power ​https://profiles.wordpress.org there might be a reason why this code is there.

[shawfactor]

Guys
What I’m requesting would have no conflicts

i just want the code wrapped by a filter so it could be turned off. The default would still be to run it.

This would have zero effect on current users of this code.

[espellcaste]

@shawfactor I get it! I personally just want to have a better understanding of what's happening there before introducing this change. :)

[shawfactor]

The function clears the entire “wp super cache” cache on any new activity. It makes sense to have filter a filter allowing this behaviour to be disabled programmatically

It is very simple and makes so I bit mystified on why there is a delay.

• As titled.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8462

[espellcaste]

In the above pull request, I suggest making the bp_core_clear_cache function "hookable". This will allow plugin and theme authors to perform cache purge actions relative to their site/setup without introducing much hassle to BuddyPress itself.

[espellcaste]

In 13398:

Make the bp_core_clear_cache function pluggable.

Closes ​https://github.com/buddypress/buddypress/pull/50
Fixes #8462