Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#8439 closed defect (bug) (fixed)

Page "Change Avatar" produces error in jQuery & prevents the avatar from resizing

Reported by: weddywood's profile WeddyWood Owned by: imath's profile imath
Milestone: 8.0.0 Priority: high
Severity: normal Version: 7.2.0
Component: Core Keywords: has-patch
Cc:

Description

Page "Change Avatar" produces error in jQuery:

Uncaught TypeError: url.indexOf is not a function

This error message comes from jQuery.fn.load function.

Because of:

.load, .unload, and .error, deprecated since jQuery 1.8, are no more. Use .on() to register listeners.
...
​jQuery Blog

You need update calls load function in file bp-core-cssjs.php (line 303):

jQuery(window).load( function(){

To:

jQuery(window).on('load', function(){

Attachments (1)

8439.patch​ (794 bytes) - added by imath 4 years ago.

Download all attachments as: .zip

Change History (3)

@imath
4 years ago

#1 @imath
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 8.0.0

Hi @WeddyWood

Thanks a lot for your report and for sharing the way to fix it. I've used it into the attached patch.

We haven't seen this because it belongs to the old way of setting an avatar (before the Avatar UI was renewed during the 2.3 release), so it's not loaded by default.

#2 @imath
4 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12857:

Remove a call to a deprecated jQuery method.

Props WeddyWood

Fixes #8439

Note: See TracTickets for help on using tickets.