Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#8427 closed defect (bug) (fixed)

Group Type Has Directory View with BuddyPress Nouveau Multiple Column

Reported by: vapvarun's profile vapvarun Owned by: imath's profile imath
Milestone: 7.2.0 Priority: normal
Severity: normal Version: 7.0.0
Component: Templates Keywords: has-patch commit
Cc:

Description

BuddyPress Nouveau offers a Multiple Column layout for Groups, it works for the directory but displays 1 column layout for Group Type Directory UI Layout.
https://screencast-o-matic.com/watch/crVF6e9XNY

Attachments (2)

8427.patch (1.9 KB) - added by imath 4 years ago.
Group Type.png (234.1 KB) - added by vapvarun 4 years ago.
Group Type Directory

Download all attachments as: .zip

Change History (9)

#1 @imath
4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 7.2.0
  • Version set to 7.0.0

Good catch, thanks a lot! I'll look at how classes are generated by BP Nouveau to try to fix this.

This ticket was mentioned in Slack in #buddypress by vapvarun. View the logs.


4 years ago

@imath
4 years ago

#3 @imath
4 years ago

  • Keywords has-patch added; needs-patch removed

Hi @vapvarun can you confirm 8427.patch is fixing the issue?

#4 @vapvarun
4 years ago

@imath yes it worked, thanks

@vapvarun
4 years ago

Group Type Directory

#5 @imath
4 years ago

  • Keywords commit added

Awesome! Thanks a lot for your confirmation 👍. Let's have it in!

#6 @imath
4 years ago

In 12836:

Nouveau: Apply columns preference when Groups loop is filtered by type

Using the customizer you can define your preferences about the number of columns the BP Nouveau Template Pack should use to display Groups into their directory page. This preference needs to also be applied when this directory page is only listing Groups matching a specific type.

Props vapvarun

See #8427 (trunk)

#7 @imath
4 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12837:

Nouveau: Apply columns preference when Groups loop is filtered by type

Using the customizer you can define your preferences about the number of columns the BP Nouveau Template Pack should use to display Groups into their directory page. This preference needs to also be applied when this directory page is only listing Groups matching a specific type.

Props vapvarun

Fixes #8427 (branch 7.0)

Note: See TracTickets for help on using tickets.