Skip to:
Content

BuddyPress.org

Opened 15 years ago

Closed 15 years ago

#841 closed defect (bug) (fixed)

Replace site_url() with $bp->root_domain

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by:
Milestone: 1.1 Priority: minor
Severity: Version:
Component: Keywords: has-patch
Cc:

Description

Everywhere else, BuddyPress uses $bp->root_domain to reference the root URL where a "/" follows it. In this case, using site_url() creates an inconsistency where plugins may previously filter site_url().

This can result in a double "/" situation that may not be caught by the affecting plugin, or that cannot be predicted due to the nature of the way WordPress builds URLs.

I know this sounds crazy, but trust me on this one.

Attachments (2)

bp-activity-templatetags(2).patch​ (579 bytes) - added by johnjamesjacoby 15 years ago.
Patch for bp-activity-templatetags.php
bp-activity-templatetags(2).2.patch​ (566 bytes) - added by GIGALinux 15 years ago.

Download all attachments as: .zip

Change History (7)

@johnjamesjacoby
15 years ago

Patch for bp-activity-templatetags.php

#1 @(none)
15 years ago

  • Milestone 1.0.2 deleted

Milestone 1.0.2 deleted

#2 @apeatling
15 years ago

  • Milestone set to 1.0.4

#3 @GIGALinux
15 years ago

Patch to work with site_url

@GIGALinux
15 years ago

#4 @apeatling
15 years ago

  • Milestone changed from 1.0.4 to 1.1

Milestone 1.0.4 deleted

#5 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1774]) Fixes #841

Note: See TracTickets for help on using tickets.