Admin Types should use the same JavaScript's UX as the WP categories

[Jean-David]

When adding a new Group Type or Member Type, the administration reload on error.
It could be better for the user experience to use Javascript too see if the fields are empty or invalid before submitting.

It would also allow to add easier and faster new types.

[imath]

Hi, thanks for your feedback.

Admin Types should use the same JavaScript's UX as the WP categories

I disagree with this, if we want to improve the UX adding some more JavaScript, imho it should not use the ones provided by the category/tag screens (ie: admin-tags & inline-edit-tax ). By the way we are dequeueing them because they don't match the BP Types needs.

I'm fine with improving src/bp-core/admin/js/types-admin.js to mimic the category/tag UI as long as we create new BP REST API endpoints for BP Types (I believe we should avoid Ajax) and use Modern JavaScript.

[Jean-David]

I agree with you, my initial point was mainly to have a validation on the client side with the JS best practices BP uses.
Should we create a new ticket for the BP Rest API for BP Types ?

[imath]

Sounds like a great plan 👍. The BP REST API is maintained from this GH repository ​https://github.com/buddypress/BP-REST you should open the issue there 😉

[imath]

I think the endpoint won't be ready soon enough.

[imath]

We haven't progressed about ​https://github.com/buddypress/BP-REST/issues/370 which is a requirement imho to inject some JavaScript there (let's avoid admin-ajax.php).