Skip to:

Opened 3 years ago

Last modified 10 months ago

#8409 new enhancement

Admin Types should use the same JavaScript's UX as the WP categories

Reported by: jean-david's profile Jean-David Owned by: slaffik's profile slaFFik
Milestone: Awaiting Contributions Priority: low
Severity: minor Version: 7.0.0
Component: Administration Keywords: needs-patch


When adding a new Group Type or Member Type, the administration reload on error.
It could be better for the user experience to use Javascript too see if the fields are empty or invalid before submitting.

It would also allow to add easier and faster new types.

Change History (7)

#1 @imath
3 years ago

  • Milestone changed from Awaiting Review to Awaiting Contributions

Hi, thanks for your feedback.

Admin Types should use the same JavaScript's UX as the WP categories

I disagree with this, if we want to improve the UX adding some more JavaScript, imho it should not use the ones provided by the category/tag screens (ie: admin-tags & inline-edit-tax ). By the way we are dequeueing them because they don't match the BP Types needs.

I'm fine with improving src/bp-core/admin/js/types-admin.js to mimic the category/tag UI as long as we create new BP REST API endpoints for BP Types (I believe we should avoid Ajax) and use Modern JavaScript.

#2 @Jean-David
3 years ago

I agree with you, my initial point was mainly to have a validation on the client side with the JS best practices BP uses.
Should we create a new ticket for the BP Rest API for BP Types ?

#3 @imath
3 years ago

Sounds like a great plan 👍. The BP REST API is maintained from this GH repository you should open the issue there 😉

#4 @imath
3 years ago

  • Milestone changed from Awaiting Contributions to 8.0.0
  • Version set to 7.0.0

#5 @imath
3 years ago

  • Milestone changed from 8.0.0 to Up Next

I think the endpoint won't be ready soon enough.

#6 @imath
17 months ago

  • Milestone changed from Up Next to 12.0.0

#7 @imath
10 months ago

  • Keywords needs-patch added; reporter-feedback removed
  • Milestone changed from 12.0.0 to Awaiting Contributions

We haven't progressed about which is a requirement imho to inject some JavaScript there (let's avoid admin-ajax.php).

Note: See TracTickets for help on using tickets.