Blogs component: the item's site icon is not necessarily used

[imath]

When BuddyPress is not network activated on a multisite configuration, it will only succeed to synchronize site icon with blavatar for the BP root blog.

The attached patch is fixing things for this configuration and compensate the synchronization lost with a new repair tool to update site icon's BP blog metadata.

I believe we should include this in 7.0.0 as we've been working on the new default blavatar.

[vapvarun]

@imath, when we have BP active at the root site, any changes for site icons on a subsite, are not reflecting on the Site Directory page.

In the case of BP network active, site icon changes on subsite are reflecting the same at Site Directory page.

[imath]

@vapvarun thanks for your testing. Have you tried the BP repair tool I’ve added to see if it fixes the issue when BP is not network activated ?

[wbcomdesigns]

@imath yes, also checked repair tool, and worked as expected
Test case
First activated BP network-wide and set site icons for each subsite
Deactivated BP from network-wide and activated BP at the root site
Change Site icons for 1 subsite and root site, the site directly was still displaying the old site icon for the subsite.
After executing the repair tool it reflected the newly set site icon for subsite on the directory page.
​https://screencast-o-matic.com/watch/cYX6lgMxfH

[imath]

In 12779:

BP Blogs: improve Site Icons / Blavatar synchronization

Make sure BuddyPress tries to synchronize Sites Icons / Blavatars even when it's not network activated.

Add a new BP Repair tool to repair this synchronization. This can be needed when a different site of the network has its site icon updated after the BuddyPress Sites directory already listed this site previously.

Props vapvarun

Fixes #8384

[imath]

In 12784:

Add missing translators comment

See #8384