Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#8377 closed defect (bug) (fixed)

BP Activity Embed Block chosen URL is wrongly reset

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 7.0.0 Priority: normal
Severity: normal Version:
Component: Activity Keywords: has-patch
Cc:

Description

This causes the Activity Embed to only be rendered when edited again.

This PR ​bp-blocks#31 is fixing the issue.

Change History (3)

This ticket was mentioned in ​Slack in #buddypress by imath. ​View the logs.
4 years ago

#2 @imath
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 12763:

BP Blocks: make sure the Activity Embed block renders the activity

The Activity permalink URL was wrongly reset to an empty string the first time the embed request was made. As a result the error state of the block was rendered.

This commit fixes this issue and brings some complementary improvements:

  • Stop using the deprecated Toolbar Block component in favor of the ToolbarGroup one.
  • Use the Disabled Block component to disable links inside the rendered activity.

Fixes #8377

This ticket was mentioned in ​Slack in #buddypress by imath. ​View the logs.
4 years ago

Note: See TracTickets for help on using tickets.