Skip to:
Content

BuddyPress.org

Opened 12 months ago

Last modified 2 weeks ago

#8368 new defect (bug)

bp_notifications_get_notifications_for_user should return additional objects

Reported by: shawfactor Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version:
Component: Core Keywords: needs-patch
Cc:

Description

Right now the function bp_notifications_get_notifications_for_user returns an array with content and href objects (along with the usual other objects for the notifcation).

This means the function is only really useful in the context of a buddypress theme. Yet ideally you would connect this function to a toast library or the web push api.

So I think adding (at the very least) adding the title and some of the options for the web push api, would make this function much more versatile and useful:

https://developer.mozilla.org/en-US/docs/Web/API/Notification/Notification

Change History (1)

#1 @imath
2 weeks ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Awaiting Contributions

Why not! I'd like to see a patch about it. If someone builds a patch about it, I'll be happy to review it.

Helpful doc: https://codex.buddypress.org/participate-and-contribute/contribute-with-code/

Note: See TracTickets for help on using tickets.