Skip to:
Content

BuddyPress.org

Opened 3 years ago

Last modified 4 months ago

#8368 assigned defect (bug)

bp_notifications_get_notifications_for_user should return additional objects

Reported by: shawfactor's profile shawfactor Owned by:
Milestone: 12.0.0 Priority: normal
Severity: normal Version:
Component: Core Keywords: needs-patch
Cc:

Description

Right now the function bp_notifications_get_notifications_for_user returns an array with content and href objects (along with the usual other objects for the notifcation).

This means the function is only really useful in the context of a buddypress theme. Yet ideally you would connect this function to a toast library or the web push api.

So I think adding (at the very least) adding the title and some of the options for the web push api, would make this function much more versatile and useful:

​https://developer.mozilla.org/en-US/docs/Web/API/Notification/Notification

Change History (6)

#1 @imath
21 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Awaiting Contributions

Why not! I'd like to see a patch about it. If someone builds a patch about it, I'll be happy to review it.

Helpful doc: ​https://codex.buddypress.org/participate-and-contribute/contribute-with-code/

This ticket was mentioned in ​Slack in #buddypress by imath. ​View the logs.
21 months ago

#3 @rafiahmedd
10 months ago

@shawfactor, I will be happy to implement this feature however can you please add some more details on this? So that I can start the implemantation. I will wait for your comment. 😊

Thanks

#4 @espellcaste
5 months ago

  • Milestone changed from Awaiting Contributions to Up Next
  • Owner set to espellcaste
  • Status changed from new to assigned

#5 @imath
5 months ago

  • Milestone changed from Up Next to 12.0.0

#6 @espellcaste
4 months ago

  • Owner espellcaste deleted
Note: See TracTickets for help on using tickets.