Block based Activity post form

[imath]

The BP Activity Block Editor is being developed from GitHub as a feature as a plugin:

​https://github.com/buddypress/bp-activity-block-editor

[imath]

I've just added a block to share a post/page via the activity stream that used the Block Based Activity Post form into a modal. This gives you a preview of how we could slowly introduce this new post form into 7.0.0.

For more info about this: ​https://github.com/buddypress/bp-blocks/pull/11

[imath]

The pull request has been merged into the BP Blocks plugin. We made great progress during the 7.0.0 development cycle. The Activity post form made it possible to add a block to share a post/page into the activity stream. @espellcaste brought great improvements to the plugin organization lately, but we need more time to :

• ​Allow users to edit their activities,
• ​Allow users to list & manage their activities in WP admin screen

Let's work on it to try to have it ready for 8.0.0

[imath]

We need more time to progress on this.

[imath]

Here's a screenshot of the Block Activity Editor.

Progress:
[x] Activity WP Admin screen posting
[x] Editing an Activity from the Activity WP Admin screen.
[x] Replying to an Activity from the Activity WP Admin screen.
[x] Front-end posting (Directory, User profile, Group profile)
[x] Emojis Autocompleter
[x] 3rd party Activity Blocks (Test with the ​BP Attachments Add-on)
[x] Theme Compat Feature check
[x] Improvements to buddypress Theme Support to let themes opt-in to support the Activity Block Editor.
[ ] Activity WP Admin screen: build an Activity stream using the BP REST API to let any member share their content from there as well as let Community Admins moderate posted activities from there (load-more, favorite, delete, search, filters...)

Test it! -> ​https://github.com/buddypress/bp-activity-block-editor

This PR is extending the WP theme supports API to be able to check Standalone themes opted in for BP Modern features such as the Activity Block Editor.

Usage in theme:

add_theme_support(
        'buddypress',
        array(
                'activity'     => array( 'block-editor' ),
                'messages => array( 'pagination' ),
        )
);

Usage in BuddyPress:

if ( bp_current_theme_supports( array( 'activity' => 'block-editor' ) ) ) {}

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8319

[imath]

In 13912:

Introduce theme support check for specific component features

Some of the feature we'll soon introduce like the Block based activity post form will need standalone BP themes to do some adjustments to their code to support them.

Once done, they'll need to opt-in for these features using the WordPress add_theme_support() function. The first argument for this function remains buddypress. Supporting BP component specific features will need to use a second argument: an associative array keyed by BP Component IDs. For instance, it will be array( 'activity' => array( 'block-editor' ) ) when a theme support the future Block based activity post form.

In BuddyPress code, we'll then be able for example to use the following kind of check bp_current_theme_supports( array( 'activity' => 'block-editor' ) ) to be sure the theme fully support the feature.

Props espellcaste

See #8319
Closes ​https://github.com/buddypress/buddypress/pull/301

[imath]

Other needed code improvements for the Block Based activity post form will happen during next major release.

[dd32]

In [13912]:
Introduce theme support check for specific component features

@imath This has introduced PHP warnings with profiles.w.org using the bp-default parent template.

E_WARNING: array_keys() expects parameter 1 to be array, bool given in wp-content/plugins/buddypress/bp-core/bp-core-theme-compatibility.php:1093
E_WARNING: array_map(): Expected parameter 2 to be an array, null given in wp-content/plugins/buddypress/bp-core/bp-core-theme-compatibility.php:1093
E_WARNING: array_filter() expects parameter 1 to be array, null given in wp-content/plugins/buddypress/bp-core/bp-core-theme-compatibility.php:1093

​https://github.com/buddypress/buddypress/blob/f6ebb51eda2c5648f91a18666ccf5068fdca7e0d/src/bp-core/bp-core-theme-compatibility.php#L1091-L1093

What this boils down to is, $args is array(), reset( array() ) is false, array_keys( false ) is a warning and returns null.

Quick fix would be

- $params             = reset( $args );
+ $params             = reset( $args ) ?: [];

or

        $params             = reset( $args );
-       $is_expected_params = array_filter( array_map( 'is_string', array_keys( $params ) ) );
+       $is_expected_params = $params && array_filter( array_map( 'is_string', array_keys( $params ) ) );

Stack trace:

array_keys() wp-content/plugins/buddypress/bp-core/bp-core-theme-compatibility.php:1093
_bp_filter_current_theme_supports() wp-includes/class-wp-hook.php:324
apply_filters('current_theme_supports-buddypress') wp-includes/theme.php:3174
current_theme_supports() wp-content/plugins/buddypress/bp-core/bp-core-theme-compatibility.php:207
bp_detect_theme_compat_with_current_theme() wp-content/plugins/buddypress/bp-core/bp-core-theme-compatibility.php:169
bp_use_theme_compat_with_current_theme() wp-content/plugins/buddypress/bp-core/bp-core-template-loader.php:802
bp_load_theme_functions() wp-includes/class-wp-hook.php:324
do_action('bp_after_setup_theme') wp-content/plugins/buddypress/bp-core/bp-core-dependency.php:643
bp_after_setup_theme() wp-includes/class-wp-hook.php:324
do_action('after_setup_theme') wp-settings.php:678

[imath]

Ouch!! Thanks for the alert, it shouldn't according to our unit tests. I guess I missed something. Let's fix it before 14.0.0-beta2

When first activating the BP Default theme, more than PHP warnings we get a fatal error.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/8319

Hi @dd32 thanks a lot for your feedback 😍, yes I got the fatal in PHP8! I'm going to commit the fix asap.

[imath]

In 13932:

Improve how BP extends the WP Theme Support for BP Standalone Themes

To be able to check whether a BP Standalone theme supports future specific BP Component features, we are filtering current_theme_supports-buddypress using the _bp_filter_current_theme_supports() callback function.

When a theme (eg: BP Default theme) was adding a buddypress support with no extra arguments, this callback was wrongly generating PHP errors when the extra arguments were empty.

This commit is making sure these errors are gone!

Props dd32

Fixes #8319
Closes ​https://github.com/buddypress/buddypress/pull/317