Context Navigation

← Previous Ticket
Next Ticket →

#8315 closed enhancement (fixed)

Make all admin notices dismissible

Reported by:	imath	Owned by:	slaFFik
Milestone:	7.0.0	Priority:	normal
Severity:	normal	Version:
Component:	Administration	Keywords:	good-first-bug has-patch
Cc:

Description

I believe we should add the needed class to make all our admin notices dismissible.

If you're a new BuddyPress contributor, building the patch of this improvement is a good way to start contributing ;)

Attachments (2)

8315.patch (2.1 KB) - added by immeet94 4 years ago.
8315_2.patch (5.5 KB) - added by immeet94 4 years ago.: updated patch

Download all attachments as: .zip

Change History (12)

#1 @immeet94
4 years ago

Hello @imath

I am a new BuddyPress contributor if you guide me I will create patch for this.

Thanks.

#2 @misfist
4 years ago

I'd be happy to make this happen also.

Version 0, edited 4 years ago by misfist (next)

#3 @imath
4 years ago

Hi @immeet94 & @misfist

Thanks for your feedbacks. I'll write a new codex page asap as I've just noticed a tutorial to quickly get started was missing.

I've also opened this ticket #8317 which should greatly improve how to set up a development environment for BuddyPress.

In the meantime, you can:

install your local development environment following this WordPress documentation page. Desktop server seems to be the easiest one to use as it includes WordPress already (make sure to download the free version!!).
we are using SVN to manage our code if you don't have SVN installed, here's how to install it. If you prefer Git, that's probably because you already have it installed, so you can alternatively use it.
once done, using a terminal (or Windows command line tool like Powershell), browse to the /wp-content/plugins directory of your WordPress and checkout the development version of BuddyPress:
- SVN : svn co https://buddypress.svn.wordpress.org/trunk/ buddypress
- or Git : git clone git://buddypress.git.wordpress.org/ buddypress
Activate BuddyPress
Using a code editor like VSCode Edit the needed files to make all admin notices dismissible. For instance, in src/bp-activity/bp-activity-admin.php at line 1174: replace <div id="moderated" class="<?php echo ( ! empty( $_REQUEST['error'] ) ) ? 'error' : 'updated'; ?>"><p><?php echo implode( "<br/>\n", $messages ); ?></p></div> by <div id="moderated" class="<?php echo ( ! empty( $_REQUEST['error'] ) ) ? 'error' : 'updated'; ?> notice is-dismissible"><p><?php echo implode( "<br/>\n", $messages ); ?></p></div> as to make a notice dismissible, you simply need to add these two CSS classes notice is-dismissible.
Save your edits, Test them deleting an activity from the Activity Administration screen and if it's ok, build a patch!
go to your terminal app into the /wp-content/plugins/buddypress directory and run svn diff > path-to-your-patch/8315.patch if you're using SVN or git diff --no-prefix > path-to-your-patch/8315.patch if you're using Git.
the path-to-your-patch/8315.patch file is the one you'll need to upload to this ticket.
Find the other places where BuddyPress is adding admin notices and edit the needed files to build a more complete patch and upload it here.