Skip to:
Content

BuddyPress.org

Opened 3 years ago

Closed 2 years ago

#8308 closed enhancement (fixed)

2.0 - BP CLI

Reported by: espellcaste's profile espellcaste Owned by: espellcaste's profile espellcaste
Milestone: 7.0.0 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch commit
Cc:

Description

The 2.0 version of the WP BP CLI is almost 100%. https://github.com/buddypress/wp-cli-buddypress

This update was on my list of TO-DO for quite some time. It comes with several changes: https://github.com/buddypress/wp-cli-buddypress/blob/master/CHANGELOG.md

I'm creating this ticket to add a few changes to BuddyPress core to better work together with the package.

First: we need to update BuddyPress trunk with the master version of the WP BP CLI package. This will allow people using the BP Beta Tester plugin to use the latest version of the CLI. When we decide to actually launch we change for the 2.0 tag release.

Second: I'd like to add a conditional check in the plugin to make sure the package from the plugin doesn't conflict with the one installed with wp package install buddypress.

This is for people that installs the package via the cli. Right now, installing via the package fetches from master and is always the latest. But due to the class conflict, one can't use the latest if desired.

Patch incoming. :)

Attachments (2)

8308.diff (1.2 KB) - added by espellcaste 2 years ago.
8308-2.diff (1.2 KB) - added by espellcaste 2 years ago.

Download all attachments as: .zip

Change History (10)

#1 @espellcaste
3 years ago

  • Owner set to espellcaste
  • Status changed from assigned to accepted

#2 @espellcaste
3 years ago

  • Status changed from accepted to assigned

@espellcaste
2 years ago

#3 @espellcaste
2 years ago

  • Keywords has-patch added; needs-patch removed

#4 @imath
2 years ago

Looks good! Thanks for your work on the patch and on the BP CLI commands.

I'd suggest to add a space before the last ) in:
! class_exists( 'Buddypress\CLI\Command\BuddypressCommand')

@espellcaste
2 years ago

#5 @espellcaste
2 years ago

@imath I'd love your review of the new patch.

#6 @imath
2 years ago

  • Keywords commit added

Let's have it in!

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


2 years ago

#8 @espellcaste
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 12737:

Update the BP CLI package to the 2.0 version (https://github.com/buddypress/wp-cli-buddypress/releases/tag/2.0).

Also, add a conditional to avoid conflict with the BuddyPress plugin version. This makes sure
there is no conflict when the package is installed via the wp package install buddypress command.

Props imath

Fixes #8308

Note: See TracTickets for help on using tickets.