Opened 4 years ago
Closed 4 years ago
#8308 closed enhancement (fixed)
2.0 - BP CLI
Reported by: | espellcaste | Owned by: | espellcaste |
---|---|---|---|
Milestone: | 7.0.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | has-patch commit |
Cc: |
Description
The 2.0 version of the WP BP CLI is almost 100%. https://github.com/buddypress/wp-cli-buddypress
This update was on my list of TO-DO for quite some time. It comes with several changes: https://github.com/buddypress/wp-cli-buddypress/blob/master/CHANGELOG.md
I'm creating this ticket to add a few changes to BuddyPress core to better work together with the package.
First: we need to update BuddyPress trunk with the master version of the WP BP CLI package. This will allow people using the BP Beta Tester plugin to use the latest version of the CLI. When we decide to actually launch we change for the 2.0 tag release.
Second: I'd like to add a conditional check in the plugin to make sure the package from the plugin doesn't conflict with the one installed with wp package install buddypress
.
This is for people that installs the package via the cli. Right now, installing via the package fetches from master and is always the latest. But due to the class conflict, one can't use the latest if desired.
Patch incoming. :)
Looks good! Thanks for your work on the patch and on the BP CLI commands.
I'd suggest to add a space before the last
)
in:! class_exists( 'Buddypress\CLI\Command\BuddypressCommand')