BP Nouveau throwing notices on including members-loop.php

[sbrajesh]

In BP Nouveau template pack, various items loop uses 'bp_nouveau_pagination()' to show the pagination.

The problem with this function is, it checks for specific components and screens. If the fixed list of component is not current component, it throws notice as shown in attached file.

This practically makes it impossible to use the loops outside the specified context of the function.

The proposed solution is to set the default values for $pag_count, $pag_links, $page_arg and if possible allow filtering $pagination_type.

Also, to answer why we need this loop is, we include it to take the advantage by plugins.

[sbrajesh]

Debug log

[imath]

Hi @sbrajesh

Thanks for your feedback. If you can test the attached patch and confirms it's fixing the issue asap, we will be able to include the fix in 6.0.0, otherwise we'll include it in next release.

[sbrajesh]

Hi @imath
Thank you for the quick patch. It works great.
I sincerely appreciate it.

[imath]

Awesome, you're welcome, and thanks for your confirmation. I'll commit it asap.

[imath]

In 12623:

BP Nouveau: make sure custom components can define their pagination

Introduce a new filter bp_nouveau_pagination_params Plugin Authors can use to customize the pagination of the directory page of their custom component.

Props sbrajesh

Fixes #8280