Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #8270, comment 20


Ignore:
Timestamp:
05/11/2020 03:32:43 AM (6 years ago)
Author:
mercime
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #8270, comment 20

    initial v1  
    22- Changed `h2` heading of "BuddyPress 6.0.0" to an `h1` heading. Each modal is like a new document and each should have a `h1` heading so unsighted users via screen readers know what the new document is all about.
    33- Ported style from `h2` style of the Plugin detail modal to our `h1` heading.
    4 - Added `role="document"` to inner modal container to facilitate `browse mode` for NVDA, JAWS, and other assistive technologies which have that mode.
     4- While the `role="dialogue"` is good for the outer container, need to add `role="document"` to the inner modal container to facilitate `browse mode` for NVDA, JAWS, and other assistive technologies which have that mode.
    55
    66Tested 8270.a11y.patch. Thanks @imath. While it worked on TABs, it didn't work on SHIFT+TABs because it escaped the modal container and proceeded to wp-admin's footer links. One solution would be at core's [https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/admin/plugin-install.js plugin-install.js].