Member Directory nav tab Won’t Display over 999 member count

[twmcmahan]

We have 3,078 Members. When opening the member directory the pagination count(s) is correct, but the count in the tab navigation is 3.

I’ve resolved this by making a change to the function bp_nouveau_get_nav_count()

/bp-templates/bp-nouveau/includes/template.tags.php Line 1266
From:

<?php
$count = (int) $nav_item->count;

to

<?php
$count = (int) str_replace(',', '', $nav_item->count );

It appears that $nav_item->count returns 3,078 and because it’s being forced to an integer it’s only returning 3 as the code is written.

[imath]

Hi @twmcmahan

Thanks for reporting this issue. I will look at it asap to try to find a fix.

[imath]

I confirm, the reason of this issue is we're applying twice the number_format_i18n() function. Once in bp_core_number_format() and another time into bp_nouveau_nav_count(). That's one too much. 8269.patch is removing the first one to format just before output.

[imath]

In 12619:

BP Nouveau: make sure to format the total members count once only

Props twmcmahan

Fixes #8269