Skip to:
Content

BuddyPress.org

Opened 3 months ago

Closed 3 months ago

#8265 closed defect (bug) (fixed)

WordPress Update 5.4 Changed function wp_get_user_request_data()

Reported by: Dono12 Owned by: r-a-y
Milestone: 5.2.0 Priority: high
Severity: major Version: 5.0.0
Component: Settings Keywords: has-patch commit
Cc:

Description

The recent WordPress 5.4 update changed

wp_get_user_request_data()

to

wp_get_user_request().

Because this change is not yet updated in wp-content/plugins/buddypress/bp-settings/bp-settings-functions.php on line 251.

wp_get_user_request_data( $query->post->ID );

The BuddyPress Export Data Page is broken when clicking the Export Data Button.

Attachments (1)

8265.01.patch (597 bytes) - added by r-a-y 3 months ago.

Download all attachments as: .zip

Change History (8)

#1 @r-a-y
3 months ago

  • Component changed from Core to Settings
  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 6.0.0

Thanks for letting us know, Dono12.

That's annoying. WordPress didn't even deprecate the previous function? See #WP46302. Update - It looks like they did deprecate the function, but only in the admin area.

Since we need to support versions of WordPress less than 5.4, we'll need to do a function_exists() check. See attached patch. Devs, let me know if you'd prefer the function_exists() check to span multiple lines instead of a one-liner.

I'm guessing there won't be a 5.2.0 release, so I'm moving this to 6.0 in the meantime.

Last edited 3 months ago by r-a-y (previous) (diff)

@r-a-y
3 months ago

#2 @johnjamesjacoby
3 months ago

I commented on the original WordPress issue. I suspect that function was deprecated into the incorrect location.

IMO, it should be fixed upstream in 5.4.1, in addition to the one here.

Thanks @r-a-y & @Dono12 for seeing and patching this right away. 👍

#3 @r-a-y
3 months ago

I was going to open a new ticket upstream about this, but I'll wait to see what the devs say before sending a patch.

#4 @imath
3 months ago

  • Keywords commit added
  • Milestone changed from 6.0.0 to 5.2.0

Thanks a lot for the patch @r-a-y Could you commit it in 5.2 and trunk ?

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


3 months ago

#6 @r-a-y
3 months ago

In 12612:

Settings: Ensure we use the updated user request function for WordPress 5.4.0.

In WordPress 5.4.0, the wp_get_user_request_data() function was
renamed to wp_get_user_request(). See #WP46302.

Props Dono12.

See #8265 (trunk).

#7 @r-a-y
3 months ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 12613:

Settings: Ensure we use the updated user request function for WordPress 5.4.0.

In WordPress 5.4.0, the wp_get_user_request_data() function was
renamed to wp_get_user_request(). See #WP46302.

Props Dono12.

Fixes #8265 (5.0-branch).

Note: See TracTickets for help on using tickets.