Opened 5 years ago
Closed 5 years ago
#8265 closed defect (bug) (fixed)
WordPress Update 5.4 Changed function wp_get_user_request_data()
Reported by: | Dono12 | Owned by: | r-a-y |
---|---|---|---|
Milestone: | 5.2.0 | Priority: | high |
Severity: | major | Version: | 5.0.0 |
Component: | Settings | Keywords: | has-patch commit |
Cc: |
Description
The recent WordPress 5.4 update changed
wp_get_user_request_data()
to
wp_get_user_request().
Because this change is not yet updated in wp-content/plugins/buddypress/bp-settings/bp-settings-functions.php on line 251.
wp_get_user_request_data( $query->post->ID );
The BuddyPress Export Data Page is broken when clicking the Export Data Button.
Attachments (1)
Change History (8)
#1
@
5 years ago
- Component changed from Core to Settings
- Keywords has-patch added; needs-patch removed
- Milestone changed from Awaiting Review to 6.0.0
#2
@
5 years ago
I commented on the original WordPress issue. I suspect that function was deprecated into the incorrect location.
IMO, it should be fixed upstream in 5.4.1, in addition to the one here.
Thanks @r-a-y & @Dono12 for seeing and patching this right away. 👍
#3
@
5 years ago
I was going to open a new ticket upstream about this, but I'll wait to see what the devs say before sending a patch.
#4
@
5 years ago
- Keywords commit added
- Milestone changed from 6.0.0 to 5.2.0
Thanks a lot for the patch @r-a-y Could you commit it in 5.2 and trunk ?
Thanks for letting us know, Dono12.
That's annoying. WordPress didn't even deprecate the previous function? See #WP46302. Update - It looks like they did deprecate the function, but only in the admin area.
Since we need to support versions of WordPress less than 5.4, we'll need to do a
function_exists()
check. See attached patch. Devs, let me know if you'd prefer the function_exists() check to span multiple lines instead of a one-liner.I'm guessing there won't be a 5.2.0 release, so I'm moving this to 6.0 in the meantime.