Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 4 years ago

#8255 closed defect (bug) (fixed)

Add @covers entries for bp_core_get_directory_page_ids()

Reported by: utsav72640's profile utsav72640 Owned by: netweb's profile netweb
Milestone: 8.0.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch needs-docs
Cc:

Description

Need documentation improvement

static function are used in the functions but not mention in the documentation of the function.

Attachments (2)

declare.diff​ (828 bytes) - added by utsav72640 5 years ago.
BuddyPress/tests/phpunit/testcases/core/functions/bpCoreGetDirectoryPageId.php
update.diff​ (668 bytes) - added by utsav72640 5 years ago.
Updated Patch…

Download all attachments as: .zip

Change History (7)

@utsav72640
5 years ago

BuddyPress/tests/phpunit/testcases/core/functions/bpCoreGetDirectoryPageId.php

#1 @dontdream
5 years ago

Hello utsav72640,

Your ticket is correct, but your patch is not, because bp_core_get_directory_page_id() and bp_core_get_directory_page_ids() are actually two different functions.

#2 @utsav72640
5 years ago

Thanks @dontdream

We have updated patch and added.

Last edited 5 years ago by utsav72640 (previous) (diff)

@utsav72640
5 years ago

Updated Patch...

#3 @dontdream
5 years ago

Great! I'm not an expert in annotations, so I'm leaving that part to better qualified people :)

#4 @imath
4 years ago

  • Component changed from Core to Build/Test Tools
  • Milestone changed from Awaiting Review to 8.0.0
  • Owner set to netweb

Hi @utsav72640

Thanks for your report and patch, I'll commit it asap.

#5 @imath
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 12895:

Add @covers annotation for the bp_core_get_directory_page_id() tests

Props utsav72640, dontdream

Fixes #8255

Note: See TracTickets for help on using tickets.