Activity: Fatal error on admin dashboard when using `'bp_get_activity_action'` filter

[r-a-y]

If a plugin is filtering 'bp_get_activity_action' and uses more than the first argument, a fatal error occurs in the Activity dashboard.

This is because the duplicate filter in the activity dashboard's list table only uses one argument instead of three as in the real filter arguments.

Attached patch fixes this. Let me know if we need to pass the $activity object by reference. I don't think we need to, but I'm just following the convention used by the previous 'bp_get_activity_content_body' filter.

[imath]

Hi @r-a-y

Thanks a lot for your catch and patch. It looks good to me the way it is. I’m just wondering if we should fix this earlier in 5.2.0 as it’s potentially causing a fatal error.

[espellcaste]

@r-a-y or @imath

What's the status of this one? Are we gonna add it to 6.0?

[r-a-y]

It seems like v6.0.0 is the next release, so I will commit this to trunk unless there are any objections?

[espellcaste]

Let's see if @imath has any objections.

[imath]

Let’s commit it for 6.0.0 👌

[r-a-y]

In 12563:

Activity Admin: Mirror 'bp_get_activity_action' filter arguments.

The main 'bp_get_activity_action' filter uses 3 parameters. We need
to mirror all filter arguments to prevent a potential fatal error from
occurring in the activity dashboard.

Fixes #8234.

[r-a-y]

In 12564:

Activity: Minor PHPDoc audit for bp_get_activity_action() function.

See #8234, #4648.