Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#8233 closed defect (bug) (fixed)

groups_send_invites() skipping `force_resend` parameter

Reported by: boonebgorges's profile boonebgorges Owned by: boonebgorges's profile boonebgorges
Milestone: 5.2.0 Priority: normal
Severity: normal Version: 5.0.0
Component: Groups Keywords:
Cc:

Description

After 5.0, the internals of groups_send_invites() have an error in the way they set up the invitation query. See ​https://buddypress.trac.wordpress.org/browser/tags/5.1.2/src/bp-groups/bp-groups-functions.php?marks=1702-1707,1693-1700#L1671 - $args['invite_sent'] is correctly inferred from force_resend, but immediately afterward, $args is reinitialized. The two blocks in question ought to be reversed.

Attachments (1)

8233.diff​ (1.0 KB) - added by boonebgorges 5 years ago.

Download all attachments as: .zip

Change History (5)

@boonebgorges
5 years ago

#1 @boonebgorges
5 years ago

See 8233.diff​. @dcavins, could you please review?

#2 @dcavins
5 years ago

Thanks, @boonebgorges. Yes, the change you are suggesting looks correct to me. Those two blocks being inverted look like whatever the "bad patch application" version of copypasta is.

Thanks!

#3 @boonebgorges
5 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 12539:

Groups: Fix logic for force_resent in groups_send_invites().

Fixes #8233.

#4 @boonebgorges
5 years ago

In 12540:

Groups: Fix logic for force_resend in groups_send_invites().

Merges [12539] from the 5.0 branch.

Fixes #8233.

Note: See TracTickets for help on using tickets.