Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#8190 closed enhancement (fixed)

Fix PHPCS violation in bp_blogs_screen_create_a_blog()

Reported by: mukesh27's profile mukesh27 Owned by: imath's profile imath
Milestone: 6.0.0 Priority: normal
Severity: normal Version: 1.0
Component: Blogs Keywords: has-patch commit
Cc:

Description

Combine conditions and fix PHPCS As per document - ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#brace-style

Attachments (2)

8190.patch​ (714 bytes) - added by mukesh27 6 years ago.
Patch.
8190.2.patch​ (719 bytes) - added by mukesh27 6 years ago.
Updated patch.

Download all attachments as: .zip

Change History (6)

@mukesh27
6 years ago

Patch.

#1 @imath
6 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 6.0.0
  • Version set to 1.0

Hi @mukesh27

Thanks a lot for your report and patch. Could you improve its "readibility" a little adding 1 space between each ! operator and each statement. Eg: if ( ! is_multisite() ... ?

Last edited 6 years ago by imath (previous) (diff)

@mukesh27
6 years ago

Updated patch.

#2 @mukesh27
6 years ago

  • Keywords needs-refresh removed

@imath patch updated.

#3 @imath
6 years ago

  • Keywords commit added

Awesome, thanks a lot 👍

#4 @imath
6 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12514:

Blogs: combine conditions and improve code format

Props mukesh27

Fixes #8190

Note: See TracTickets for help on using tickets.