Skip to:
Content

BuddyPress.org

Opened 2 years ago

Closed 23 months ago

#8168 closed defect (bug) (fixed)

BuddyPress Email footer Error

Reported by: passoniate Owned by: DJPaul
Milestone: 6.0.0 Priority: normal
Severity: normal Version: 5.0.0
Component: Emails Keywords: has-patch commit
Cc:

Description

When i add continuous characters in Email Footer then characters out from footer container https://paste.pics/7CPAT

Attachments (4)

buddypress.jpg (110.3 KB) - added by passoniate 2 years ago.
8168.diff (237 bytes) - added by passoniate 2 years ago.
bpfix.jpg (64.7 KB) - added by passoniate 2 years ago.
8168.patch (3.3 KB) - added by imath 2 years ago.

Download all attachments as: .zip

Change History (13)

@passoniate
2 years ago

This ticket was mentioned in Slack in #buddypress by passoniate. View the logs.


2 years ago

#2 @imath
2 years ago

  • Component changed from Core to Emails
  • Milestone changed from Awaiting Review to 6.0.0
  • Owner set to DJPaul

Hi!

Thanks a lot for your report. Let's try to work on this during the 6.0.0 development cycle.

@passoniate
2 years ago

@passoniate
2 years ago

This ticket was mentioned in Slack in #buddypress by passoniate. View the logs.


2 years ago

#4 @imath
2 years ago

Nice thanks for your code, I’ll test it asap!

#5 @passoniate
2 years ago

Respectable @imath thank you for Response

@imath
2 years ago

#6 @imath
2 years ago

  • Keywords has-patch 2nd-opinion added; needs-patch removed

I've looked into it more deeply. I believe we should do the minimum styling there and I'm very close to believe we shouldn't do anything at all actually.

I've added 8168.patch to simply add a word-break rule.

I think if a plugin developer hooks to bp_before_email_footer or any other hook into the email template or if the site owner or the BuddyPress theme developer edits the template, then it's probably best to let them control how the code they're adding looks.

I'd be interested to have a second opinion about if from another member of the team 🙏.

#7 @espellcaste
23 months ago

I personally agree! I think we should do the bare minumum.

#8 @imath
23 months ago

  • Keywords commit added; 2nd-opinion removed

then let's commit it!

#9 @imath
23 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 12566:

BP Emails: make sure footer content doesn't spill outside of it

Props passoniate, espellcaste

Fixes #8168

Note: See TracTickets for help on using tickets.