Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #8163, comment 4


Ignore:
Timestamp:
11/21/2019 08:01:16 AM (5 years ago)
Author:
imath
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #8163, comment 4

    initial v1  
    33Thanks a lot for your feedback. After running our PHPCS Compat task I realized "[https://www.php.net/manual/en/language.oop5.traits.php trait]" was introduced in PHP 5.4.
    44
    5 So I guess the next possibility is to jungle a bit more renaming the class that extends `Walker_Nav_Menu` and using the old name to extend the newly named class to deal with the `...` operator.
     5So I guess the next possibility is to dance a bit more renaming the class that extends `Walker_Nav_Menu` and using the old name to extend the newly named class to deal with the `...` operator.
    66
    77I believe we should also check for WordPress 5.3 before doing this dance as extending `Walker_Nav_Menu` in PHP 5.6 & UP should generate a notice error in WordPress < 5.3.