Skip to:
Content

BuddyPress.org

Opened 11 months ago

Closed 6 months ago

#8157 closed defect (bug) (fixed)

Coding Standards: Fix CSS template packs/companion stylesheets

Reported by: man4toman Owned by: imath
Milestone: 6.0.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch commit
Cc:

Description

There is some lines that needs correction based on W3C standards.
The attached file will fix the linear-gradient and cursor values.

Attachments (3)

8157.patch (4.1 KB) - added by man4toman 11 months ago.
8157-2.patch (1.2 KB) - added by man4toman 11 months ago.
8157-3.patch (2.7 KB) - added by man4toman 7 months ago.

Download all attachments as: .zip

Change History (14)

@man4toman
11 months ago

#1 @imath
11 months ago

  • Keywords reporter-feedback added

Hi @man4toman

Thanks a lot for your contribution and patch. Unfortunately we are only applying security fixes to BP Default as we no longer maintain it actively.

Maybe you could have a look at /bp-templates/bp-legacy and /bp-templates/bp-nouveau to see if what you've found in BP Default is also inside the 2 template packs we maintain to eventually fix this there ?

#2 @man4toman
11 months ago

Hi @imath
Sure, I'll check this at throes too.

Thanks

Version 0, edited 11 months ago by man4toman (next)

#3 @man4toman
11 months ago

  • Keywords reporter-feedback removed

I checked bp-legacy and bp-nouveau and the new file attached to the ticket.

@man4toman
11 months ago

#4 @imath
11 months ago

Nice! Thanks a lot. You only found issues in Twentyseventeen’s companion stylesheet ? Have you checked buddypress.css in Legacy and bp-nouveau sass files in Nouveau ? If not, don’t feel it as a duty (although I’d be very interested to have your eyes on it 😊).

#5 @man4toman
11 months ago

I checked all css file types in these theme folders and yes, I only found 3 small issues.
But I missed sass files, I'll check sass files manually, it can be fun.

#6 @imath
11 months ago

Awesome 👏 thanks a lot.

#7 @imath
11 months ago

  • Milestone changed from Awaiting Review to 6.0.0
  • Summary changed from Coding Standards: Fix CSS for default theme to Coding Standards: Fix CSS template packs/companion stylesheets

#8 @espellcaste
7 months ago

Since @man4toman will still look into the sass files, I think it is safe to postpone this ticket to the next release.

What do you think @imath?

@man4toman
7 months ago

#9 @man4toman
7 months ago

I check all css and sass files in Legacy and Nouveau and the latest patch attached to the ticket.

@imath @espellcaste

Thanks

#10 @imath
6 months ago

  • Keywords commit added

Hi @man4toman

Thanks for updating the patch. I've just tested it. Let's include this into 6.0.

#11 @imath
6 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12571:

Template Packs: fix some CSS coding standards

Props man4toman

Fixes #8157

Note: See TracTickets for help on using tickets.