Opened 5 years ago
Closed 5 years ago
#8157 closed defect (bug) (fixed)
Coding Standards: Fix CSS template packs/companion stylesheets
Reported by: | man4toman | Owned by: | imath |
---|---|---|---|
Milestone: | 6.0.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Templates | Keywords: | has-patch commit |
Cc: |
Description
There is some lines that needs correction based on W3C standards.
The attached file will fix the linear-gradient and cursor values.
Attachments (3)
Change History (14)
#3
@
5 years ago
- Keywords reporter-feedback removed
I checked bp-legacy
and bp-nouveau
and the new file attached to the ticket.
#4
@
5 years ago
Nice! Thanks a lot. You only found issues in Twentyseventeen’s companion stylesheet ? Have you checked buddypress.css in Legacy and bp-nouveau sass files in Nouveau ? If not, don’t feel it as a duty (although I’d be very interested to have your eyes on it 😊).
#5
@
5 years ago
I checked all css file types in these theme folders and yes, I only found 3 small issues.
But I missed sass files, I'll check sass files manually, it can be fun.
#7
@
5 years ago
- Milestone changed from Awaiting Review to 6.0.0
- Summary changed from Coding Standards: Fix CSS for default theme to Coding Standards: Fix CSS template packs/companion stylesheets
#8
@
5 years ago
Since @man4toman will still look into the sass files, I think it is safe to postpone this ticket to the next release.
What do you think @imath?
#9
@
5 years ago
I check all css and sass files in Legacy and Nouveau and the latest patch attached to the ticket.
@imath @espellcaste
Thanks
Hi @man4toman
Thanks a lot for your contribution and patch. Unfortunately we are only applying security fixes to BP Default as we no longer maintain it actively.
Maybe you could have a look at
/bp-templates/bp-legacy
and/bp-templates/bp-nouveau
to see if what you've found in BP Default is also inside the 2 template packs we maintain to eventually fix this there ?