Skip to:

Opened 5 years ago

Closed 4 years ago

#8157 closed defect (bug) (fixed)

Coding Standards: Fix CSS template packs/companion stylesheets

Reported by: man4toman's profile man4toman Owned by: imath's profile imath
Milestone: 6.0.0 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch commit


There is some lines that needs correction based on W3C standards.
The attached file will fix the linear-gradient and cursor values.

Attachments (3)

8157.patch (4.1 KB) - added by man4toman 5 years ago.
8157-2.patch (1.2 KB) - added by man4toman 5 years ago.
8157-3.patch (2.7 KB) - added by man4toman 4 years ago.

Download all attachments as: .zip

Change History (14)

5 years ago

#1 @imath
5 years ago

  • Keywords reporter-feedback added

Hi @man4toman

Thanks a lot for your contribution and patch. Unfortunately we are only applying security fixes to BP Default as we no longer maintain it actively.

Maybe you could have a look at /bp-templates/bp-legacy and /bp-templates/bp-nouveau to see if what you've found in BP Default is also inside the 2 template packs we maintain to eventually fix this there ?

#2 @man4toman
5 years ago

Hi @imath
Sure, I'll check this at those too.


Last edited 5 years ago by man4toman (previous) (diff)

#3 @man4toman
5 years ago

  • Keywords reporter-feedback removed

I checked bp-legacy and bp-nouveau and the new file attached to the ticket.

5 years ago

#4 @imath
5 years ago

Nice! Thanks a lot. You only found issues in Twentyseventeen’s companion stylesheet ? Have you checked buddypress.css in Legacy and bp-nouveau sass files in Nouveau ? If not, don’t feel it as a duty (although I’d be very interested to have your eyes on it 😊).

#5 @man4toman
5 years ago

I checked all css file types in these theme folders and yes, I only found 3 small issues.
But I missed sass files, I'll check sass files manually, it can be fun.

#6 @imath
5 years ago

Awesome 👏 thanks a lot.

#7 @imath
5 years ago

  • Milestone changed from Awaiting Review to 6.0.0
  • Summary changed from Coding Standards: Fix CSS for default theme to Coding Standards: Fix CSS template packs/companion stylesheets

#8 @espellcaste
4 years ago

Since @man4toman will still look into the sass files, I think it is safe to postpone this ticket to the next release.

What do you think @imath?

4 years ago

#9 @man4toman
4 years ago

I check all css and sass files in Legacy and Nouveau and the latest patch attached to the ticket.

@imath @espellcaste


#10 @imath
4 years ago

  • Keywords commit added

Hi @man4toman

Thanks for updating the patch. I've just tested it. Let's include this into 6.0.

#11 @imath
4 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12571:

Template Packs: fix some CSS coding standards

Props man4toman

Fixes #8157

Note: See TracTickets for help on using tickets.