Skip to:

Opened 13 days ago

Last modified 7 hours ago

#8156 new enhancement

Move the Local Avatar and Cover Image features into the Members component.

Reported by: imath Owned by:
Milestone: 6.0.0 Priority: high
Severity: normal Version: 1.0
Component: Members Keywords: has-patch dev-feedback


The team have been discussing a lot about the fact local avatars and cover images for users should be Members features instead of xProfile features.

The consensus is: it makes more sense to include these features into the Members component.

I've been looking at it lately and unlike what I was thinking there's are no template changes needed to make this happen. So that's good news!

The most important part of the attached patch is about how to manage the navigation items. I'm suggesting to keep how the navigation is built when the xProfile is active so that users feel nothing has changed.

When the xProfile is not active, the navigation items for the 2 features will be attached to the wp-profile fallback profile we already use.

There are a lot of changes under the hood! But I've tried to deprecate the less functions I could to limit possible risks with plugins hooking to xProfile actions or filters about avatars or cover images.

I'd really like if we could commit the changes asap so that we can inform about them early during the 6.0.0 development cycle.

Thanks in advance for your time reviewing the patch.

Attachments (2)

8156.patch (62.7 KB) - added by imath 13 days ago.
8156.2.patch (64.2 KB) - added by imath 13 days ago.

Download all attachments as: .zip

Change History (4)

13 days ago

13 days ago

#1 @imath
13 days ago

Now that [12488] has been committed, 8156.2.patch has been updated to make sure I'm not forgetting to move back the Member Avatar REST Controller inside the BP Members Component.

This ticket was mentioned in Slack in #buddypress by imath. View the logs.

7 hours ago

Note: See TracTickets for help on using tickets.