Move the Local Avatar and Cover Image features into the Members component.

[imath]

The team have been discussing a lot about the fact local avatars and cover images for users should be Members features instead of xProfile features.

The consensus is: it makes more sense to include these features into the Members component.

I've been looking at it lately and unlike what I was thinking there's are no template changes needed to make this happen. So that's good news!

The most important part of the attached patch is about how to manage the navigation items. I'm suggesting to keep how the navigation is built when the xProfile is active so that users feel nothing has changed.

When the xProfile is not active, the navigation items for the 2 features will be attached to the wp-profile fallback profile we already use.

There are a lot of changes under the hood! But I've tried to deprecate the less functions I could to limit possible risks with plugins hooking to xProfile actions or filters about avatars or cover images.

I'd really like if we could commit the changes asap so that we can inform about them early during the 6.0.0 development cycle.

Thanks in advance for your time reviewing the patch.

[imath]

Now that [12488] has been committed, 8156.2.patch has been updated to make sure I'm not forgetting to move back the Member Avatar REST Controller inside the BP Members Component.

[imath]

.3.patch is a refreshed version of .2.patch which also include deprecated filters for the dynamic ones I've missed in .2.patch. I believe the patch is ready to be committed. I will try to process in consistent steps instead of a unique commit.

I've tested everything once more :

• Legacy xProfile inactive
• Legacy xProfile active
• Nouveau xProfile inactive
• Nouveau xProfile active.

Green lights for all these tests.

[imath]

In 12553:

Move Avatars & Cover from xProfile to Members component : step 1

Move Avatar and Cover settings into the Members settings section.

See #8156

[imath]

In 12554:

Move Avatars & Cover from xProfile to Members component : step 2

Move User Avatar's management from the xProfile User Admin to the Members User Admin class.

See #8156

[imath]

In 12555:

Move Avatars & Cover from xProfile to Members component : step 3

Move the Avatar upload directory filter from the xProfile functions to the Members functions.
Move the Avatar template functions from xProfile to the Members component.

See #8156

[imath]

In 12556:

Move Avatars & Cover from xProfile to Members component : step 4

Add Avatar change and delete handlers to the Members component.

See #8156

[imath]

In 12557:

Move Avatars & Cover from xProfile to Members component : step 4 (bis)

Include the files missed in r12556

See #8156

[imath]

In 12558:

Move Avatars & Cover from xProfile to Members component : step 5

• Adapt Cover functions to relate to the Members component.
• Deprecate functions no more used.
• Add the handler to change the cover into the Members component.

See #8156

[imath]

In 12559:

Move Avatars & Cover from xProfile to Members component : step 6

Move the Avatars & Cover navigation and the Avatars REST Controllers from the xProfile Component to the Members one.

See #8156

[imath]

In 12560:

Move Avatars & Cover from xProfile to Members component : step 7

Remove the xProfile handlers about Avatars and Cover now handled from the Members component.

Fixes #8156

[imath]

There's a missing step: we should make sure using bp_is_active( 'xprofile', 'cover_image' ) returns bp_is_active( 'members', 'cover_image' ) and inform this is no more the right way to check if the cover image is active.

[imath]

bp_is_active( 'xprofile', 'cover_image' ) deprecation notice.

[imath]

In 12561:

"Map" the xProfile cover image feature check to the Members one.

• If a developer uses bp_is_active( 'xprofile', 'cover_image' ) return bp_is_active( 'member', 'cover_image' ) and inform it's no more the right way to check for the cover image feature.
• deprecated the bp_is_profile_cover_image_active filter.

Fixes #8156

[imath]

Ouch, I just noticed I missed to deprecate 2 functions. It should be the last thing I've missed 🙈.

[imath]

Missing functions to deprecate

[imath]

In 12562:

Deprecate xProfile functions about avatar & cover image change

The two functions are:

• xprofile_screen_change_cover_image()
• xprofile_screen_change_avatar()

Fixes #8156

[imath]

In 12851:

The new_avatar activity belongs to the Members component

The activity generated when members add/update their profile photo wasn't migrated to the Members component during the 6.0.0 milestone. This commit's goal is to repare this oversight.

See #8156
See #8407
Fixes #8408