Skip to:
Content

BuddyPress.org

Opened 11 months ago

Last modified 11 months ago

#8133 assigned defect (bug)

Broken dropdown filter on friends page with a custom friends slug

Reported by: mattneil Owned by: imath
Milestone: Up Next Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: has-patch needs-testing early
Cc:

Description

I set a custom BP_FRIENDS_SLUG, and the dropdown filter on my new friends page was empty.

It appears to be working after I replaced 'friends' with my new slug on lines 2021, 2064 and 2106 of bp-templates/bp-nouveau/includes/template-tags.php and lines 538 and 539 of bp-templates/bp-nouveau/includes/functions.php.

Attachments (1)

8133.patch (7.0 KB) - added by imath 11 months ago.

Download all attachments as: .zip

Change History (4)

#1 @mattneil
11 months ago

  • Summary changed from No dropdown filter on friends page with a custom friends slug to Broken dropdown filter on friends page with a custom friends slug

#2 @imath
11 months ago

  • Component changed from Core to Templates
  • Keywords needs-patch added
  • Version set to 3.0.0

Hi @mattneil

Thanks a lot for your feedback. I've just tested and was able to reproduce the issue. This is a bug specific to the BP Nouveau Template pack.

I'm working on a fix. I will keep you updated about my progress.

@imath
11 months ago

#3 @imath
11 months ago

  • Keywords has-patch needs-testing early added; needs-patch removed
  • Milestone changed from Awaiting Review to Up Next
  • Owner set to imath
  • Status changed from new to assigned

I'm sorry @mattneil fixing this issue will require more testing and we're too close to release 5.0.0 to take the risk to break the dropdown for the majority of users that don't customize slugs this way.

I've quickly built a patch to fix the bug, but we'll need to improve it and test potential regressions. We'll work on it during our next major development cycle (6.0.0).

Note: See TracTickets for help on using tickets.