Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#8130 closed defect (bug) (fixed)

Translation placeholder misuse in a REST API function

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 5.0.0 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch commit
Cc:

Description

In bp-core/bp-core-rest-api.php:242

"The member type you provided, %$1s, is not one of %$2s." should be "The member type you provided, %1$s, is not one of %2$s".

Attachments (1)

8130.patch​ (767 bytes) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (4)

@imath
5 years ago

#1 @imath
5 years ago

  • Keywords has-patch commit added; needs-patch good-first-bug removed

8130 is fixing the issue. It also make sure the error code is consistent with the error message.

This ticket was mentioned in ​Slack in #buddypress by imath. ​View the logs.
5 years ago

#3 @imath
5 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12455:

Fix wrong Gettext placeholders in bp_rest_validate_member_types()

The right Gettext placeholders are %1$s and %2$s.

Fixes #8130

Note: See TracTickets for help on using tickets.