Opened 5 years ago
Closed 5 years ago
#8128 closed enhancement (fixed)
BP Nouveau JS: Maybe move "bp_ajax_request" event to fadeIn complete function.
Reported by: | dcavins | Owned by: | dcavins |
---|---|---|---|
Milestone: | 5.0.0 | Priority: | normal |
Severity: | normal | Version: | 4.4.0 |
Component: | Templates | Keywords: | has-patch commit |
Cc: | dcavins |
Description
As is, the very useful bp_ajax_request
js event fires before the element it is referring to is fully faded in, which causes problems in some cases (like drawing new elements via js, because the elemtent isn't full size until the fadeIn is completed).
I'm attaching a patch that moves the event to the optional completed
method of the fadeIn
function.
However, I can imagine that soemtimes you might want to be alerted that the request has finished before the element has completely faded in, so it might be better to add a new event, like `'bp_ajax_request_fade_in_complete' rather than moving the existing event.
I'm not sure. Anyway, thanks for your consideration.
Moves
bp_ajax_request
to fadeIn complete in Nouveau.