Possible DB error during BP 5.0.0 upgrade

[imath]

In [12429] was introduced the function to migrate existing "old" group invites into the new way of managing the Group Invites, see bp_groups_migrate_invitations(). This works fine, unless there are no invites to migrate 😬. In this case we get a DB error.

@dcavins could you review the patch and take this ticket in charge?

[johnjamesjacoby]

👍

---

Should be empty( $records ) instead of ! to avoid type juggling.

(It is checking for a non-empty result, but get_results() returns array|object|null – not a boolean.)

Cleaning all of those up could probably it's own issue at this point though, so I'm OK with either.

[dcavins]

In 12445:

Invitations: Stop migration if no invitations are found.

If no invitations are found in the group invitations migration routine, stop the migration.

Props imath.

Fixes #8127.

[dcavins]

In 12446:

Invitations: Improve migration logic.

Per jjj: "Should be empty( $records ) instead of ! to avoid type juggling."

Props jjj.

See #8127.

[dcavins]

Thanks @jjj and @imath! I had to do some work to expose the error, but the patch resolved it as expected.

Thanks again!