Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#8120 closed defect (bug) (fixed)

Activity Action strings are not generated for nested activity comments

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 5.0.0 Priority: normal
Severity: normal Version: 2.0
Component: Activity Keywords: has-patch commit
Cc:

Description

This ​issue posted on the BP REST API repository revealed we are not generating the activity comments action strings when they are appended to their parent into their parent's children property.

I suggest the attached patch and unit test to fix the bug there and the issue into the BP REST API repository.

Attachments (1)

8120.patch​ (2.5 KB) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (4)

@imath
5 years ago

#1 @espellcaste
5 years ago

Seems good to me! Thanks for getting that patched so quick! :)

Last edited 5 years ago by espellcaste (previous) (diff)

#2 @imath
5 years ago

  • Keywords commit added

Thanks for your feedback @espellcaste I will commit asap ;)

#3 @imath
5 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 12420:

Make sure activity comments action strings are generated at run-time

Fixes #8120

Note: See TracTickets for help on using tickets.