#8021 closed defect (bug) (fixed)
BP Legacy - Export Data page - Erase Data section missing
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 11.0.0 | Priority: | normal |
Severity: | normal | Version: | 4.0.0 |
Component: | Templates | Keywords: | good-first-bug has-patch |
Cc: |
Description
Comparing the Legacy Pages to the Nouveau pages I can see the legacy Export Data page is missing the Erase Data section.
Looking at settings bp_legacy/buddypress/members/single/settings/data.php I can see that section is missing from the template page.
Presumably this is a simple case of copying across the title and content from the existing nouveau template page?
Attachments (1)
Change History (10)
#1
@
6 years ago
- Keywords needs-patch good-first-bug added
- Milestone changed from Awaiting Review to Awaiting Contributions
- Version changed from 4.1.0 to 4.0.0
This ticket was mentioned in PR #23 on buddypress/buddypress by tahmid-ul.
2 years ago
#2
- Keywords has-patch added; needs-patch removed
The legacy template for Data Export page was missing the erase data section at the bottom. Added the missing section from the Nouveau template
Trac ticket: https://buddypress.trac.wordpress.org/ticket/8021
tahmid-ul commented on PR #23:
2 years ago
#3
Hi @imath, this is my first pull request in buddypress. I would be glad if you could review the PR.
2 years ago
#4
Hi @tahmid-ul
I just did 😉 . It's looking nice. I'll commit it shortly. Thanks a lot for your help.
#5
@
2 years ago
- Milestone changed from Awaiting Contributions to 11.0.0
The patch is using the code shared by @tahmid-ul into his PR + some complementary improvements:
- Avoid
is_super_admin( $user_id )
in favor of a cap check. - Remove some commented code which was duplicated from a previous section into the legacy settings/data template.
- Escape URLs and translated string.
- Do not show the link to delete an account to the administrator viewing their account as he is redirected to the member's home page when trying to reach the delete-account screen (Admins cannot delete their account form front end).
2 years ago
#6
Hey @tahmid-ul do you have a username on WordPress.org? If so, don't hesitate to add it here in a new comment, I need it to include props/credits to you into my commit message.
Yes, if it's missing, it's probably just an oversight.