Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 21 months ago

Last modified 21 months ago

#8021 closed defect (bug) (fixed)

BP Legacy - Export Data page - Erase Data section missing

Reported by: venutius's profile Venutius Owned by: imath's profile imath
Milestone: 11.0.0 Priority: normal
Severity: normal Version: 4.0.0
Component: Templates Keywords: good-first-bug has-patch
Cc:

Description

Comparing the Legacy Pages to the Nouveau pages I can see the legacy Export Data page is missing the Erase Data section.

Looking at settings bp_legacy/buddypress/members/single/settings/data.php I can see that section is missing from the template page.

Presumably this is a simple case of copying across the title and content from the existing nouveau template page?

Attachments (1)

8021.patch (5.3 KB) - added by imath 21 months ago.

Download all attachments as: .zip

Change History (10)

#1 @boonebgorges
6 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Awaiting Contributions
  • Version changed from 4.1.0 to 4.0.0

Yes, if it's missing, it's probably just an oversight.

This ticket was mentioned in PR #23 on buddypress/buddypress by tahmid-ul.


21 months ago
#2

  • Keywords has-patch added; needs-patch removed

The legacy template for Data Export page was missing the erase data section at the bottom. Added the missing section from the Nouveau template

Trac ticket: https://buddypress.trac.wordpress.org/ticket/8021

tahmid-ul commented on PR #23:


21 months ago
#3

Hi @imath, this is my first pull request in buddypress. I would be glad if you could review the PR.

imath commented on PR #23:


21 months ago
#4

Hi @tahmid-ul

I just did 😉 . It's looking nice. I'll commit it shortly. Thanks a lot for your help.

@imath
21 months ago

#5 @imath
21 months ago

  • Milestone changed from Awaiting Contributions to 11.0.0

The patch is using the code shared by @tahmid-ul into his PR + some complementary improvements:

  • Avoid is_super_admin( $user_id ) in favor of a cap check.
  • Remove some commented code which was duplicated from a previous section into the legacy settings/data template.
  • Escape URLs and translated string.
  • Do not show the link to delete an account to the administrator viewing their account as he is redirected to the member's home page when trying to reach the delete-account screen (Admins cannot delete their account form front end).

imath commented on PR #23:


21 months ago
#6

Hey @tahmid-ul do you have a username on WordPress.org? If so, don't hesitate to add it here in a new comment, I need it to include props/credits to you into my commit message.

tahmid-ul commented on PR #23:


21 months ago
#7

Hey @tahmid-ul do you have a username on WordPress.org? If so, don't hesitate to add it here in a new comment, I need it to include props/credits to you into my commit message.

Hey @imath, Here is my WordPress.org username - tahmidulkarim

Thank you!

#8 @imath
21 months ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 13327:

Settings: put the Legacy template pack’s in line with Nouveau’s one

Makes sure, just like the BP Nouveau template pack, the BP Legacy’s members/single/settings/data.php template contains a section to inform how the user can completely remove their data. This commit also brings some complementary improvements:

  • Avoid is_super_admin( $user_id ) usage in favor of a capability check.
  • Remove some commented code which was duplicated from a previous section into the legacy settings/data template.
  • Escape URLs and translated strings.
  • Improve `/* Translators: */ inline comment.
  • Do not show the link to delete an account to an administrator viewing their account as they are redirected to the member's home page when trying to reach the delete-account screen (Admins cannot delete their account form front end).

Props Venutius, tahmidulkarim

Closes https://github.com/buddypress/buddypress/pull/23
Fixes #8021

imath commented on PR #23:


21 months ago
#9

Thanks! I've just committed ;)

Note: See TracTickets for help on using tickets.