Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#8020 closed enhancement (fixed)

Make 'Download Personal Data' link more obvious

Reported by: pooja1210's profile pooja1210 Owned by: boonebgorges's profile boonebgorges
Milestone: 5.0.0 Priority: normal
Severity: normal Version: 4.0.0
Component: Settings Keywords: has-patch 2nd-opinion
Cc:

Description

After Data is export request is sent and the request is completed, text is shown in Export data page "You may download your personal data by clicking on the link below. " but there is no link provided below.

Please check that, either link needs to be provided to download personal data, or the the text needs to be changed as it is misleading.

Attachments (3)

download-link.png (29.6 KB) - added by pooja1210 6 years ago.
8020.patch (483 bytes) - added by JarretC 6 years ago.
Underlines links in paragraphs in item-body div
8020.1.patch (2.7 KB) - added by imath 6 years ago.

Download all attachments as: .zip

Change History (11)

#1 @boonebgorges
6 years ago

  • Keywords reporter-feedback added

Hi @pooja1210 - Thanks for the report.

The 'Download personal data' text below the 'You may download...' text ought to be a link. What happens when you hover over it/click it? Is it not a link? (<a href...>)? Or is it a link with an empty href value?

#2 @boonebgorges
6 years ago

  • Component changed from Core to Members
  • Version set to 4.0.0

#3 @pooja1210
6 years ago

@boonebgorges

Hello,

On hover to 'Download personal data' text, only cursor is changed, but before hovering it user will not be able to identify it as the link.

So, I think we can underline the text for better clarity.

Thanks

#4 @boonebgorges
6 years ago

  • Keywords needs-patch good-first-bug added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 5.0.0
  • Summary changed from No link is provided to download personal data to Make 'Download Personal Data' link more obvious
  • Type changed from defect (bug) to enhancement

Thanks for clarifying. I'm going to rename this ticket to better describe what's being requested.

@JarretC
6 years ago

Underlines links in paragraphs in item-body div

#5 @boonebgorges
6 years ago

Looks great. Thank you @JarretC !

#6 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 12352:

Better link styling for "Export Data" link.

Props JarretC.
Fixes #8020.

#7 @imath
6 years ago

  • Component changed from Members to Settings
  • Keywords has-patch 2nd-opinion added; needs-patch good-first-bug removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Hi !

@boonebgorges I've found grunt commit was removing the rules added by [12352] each time the task is used. I think we need to use the bp-nouveau/common-styles/_bp_user_settings.scss file to put the needed rules to better style the links into the data export user screen.

I'm reopening the ticket to eventually discuss about my suggestion to fix the issue using grunt commit.

See 8020.1.patch

@imath
6 years ago

#8 @imath
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 12394:

Better link styling for "Export Data" link.

Make sure to generate the Data Export CSS rules using grunt commit and the SCSS process.

Props JarretC, boonebgorges.

Fixes #8020

Note: See TracTickets for help on using tickets.