PHP warning when getting BuddyPress page title part

[Venutius]

I've been getting the following error in my logs:

reset() expects parameter 1 to be array, boolean given
Type: PHP Warning
Line: 3038
File: /wp-content/plugins/buddypress/bp-core/bp-core-template.php

Line 3038 has:

if ( ! empty( $bp->members->nav ) ) {
        $primary_nav_item = $bp->members->nav->get_primary( array( 'slug' => $component_id ), false );
        $primary_nav_item = reset( $primary_nav_item );
}

I had a play and one way of dealing with the issue could be:

if ( ! empty( $bp->members->nav ) ) {
        $primary_nav_item = $bp->members->nav->get_primary( array( 'slug' => $component_id ), false );
        $primary_nav_item = reset( $arr = array($primary_nav_item) );
                }

[Venutius]

That fix was not good, now getting the following error:

[21-Nov-2018 21:00:40 UTC] PHP Notice: Only variables should be passed by reference in /wp-content/plugins/buddypress/bp-core/bp-core-template.php on line 3039.

I'm not able to replicate this as yet, It's a live site and this error just seems to come in randomly. The last time I got it, I had installed a new plugin BWS Error Log, disabled another WP Error Log and saved the new settings of the BWS plugin, it went to view the error log and the error appeared so I'm not sure it's me that's triggering it.

[Venutius]

My latest fix is to wrap a check to see if the variable is an array:

if ( ! empty( $bp->members->nav ) ) {
        $primary_nav_item = $bp->members->nav->get_primary( array( 'slug' => $component_id ), false );
        if ( is_array( $primary_nav_item ) ) {
                $primary_nav_item = reset( $primary_nav_item );
        }
}

[DJPaul]

get_primary looks like it can return boolean false. We just need to handle that case in the code you mentioned. Good find!

[klawton]

Hello, I've been getting the same error with my project so I added a check to make sure $primary_nav_item is not false which seems to be working for me. I replaced

$primary_nav_item = $bp->members->nav->get_primary( array( 'slug' => $component_id ), false );
$primary_nav_item = reset( $primary_nav_item );

with

$primary_nav_item = $bp->members->nav->get_primary( array( 'slug' => $component_id ), false );
$primary_nav_item = $primary_nav_item ? reset( $primary_nav_item ) : $primary_nav_item;

My first time contributing here so if there is a better place to put fixes i'll be happy to repost there.

[espellcaste]

This is something we can do at the next milestone.

[espellcaste]

Suggested patch added! The approach seems ok to me.

[imath]

Hi @espellcaste

I think I’d do something like this :

$primary_nav_item = (array) $bp->members->nav->get_primary( array( 'slug' => $component_id ), false );
$primary_nav_item = reset( $primary_nav_item );

[espellcaste]

In 12332:

Casting the $primary_nav_item variable to an array when fetching the nav primary item to avoid PHP warning.

The get_primary method returns false when there is no nav primary item assigned. The false value returned triggered PHP warning when trying to get the first value of the array with reset.

Props imath, klawton

Fixes #8005

[johnjamesjacoby]

This debug warning has recently started clogging up some log files on BuddyPress.org.

I'm going to merge this change to plugins.svn.wordpress.org/buddypress/trunk to silence them.

[Maniou]

Hi @johnjamesjacoby
Is it planned to release this fix on master ?
Thank you :)