Support 'user_ids' argument in 'bp_has_members()`

[Mamaduka]

This task requires BP_Core_Members_Template::construct() refactoring to use array-style arguments. Patch is provided in #3797.

Changes will also affect following classes/functions:

• BP_Core_Members_Template
• bp_core_get_users()

[boonebgorges]

This looks like a good and easy improvement.

[boonebgorges]

Oh, I see now that we have to change the function signature of BP_Core_Members_Template first. This is more work that should be supported by tests. Let's do it next.

[Mamaduka]

Replying to boonebgorges:

Oh, I see now that we have to change the function signature of BP_Core_Members_Template first. This is more work that should be supported by tests. Let's do it next.

Thanks for Boone.

Should I add unit test for user_ids argument?

[boonebgorges]

Thanks, George! I'm more concerned about having tests for the changes in ​https://buddypress.trac.wordpress.org/attachment/ticket/3797/3797.core-members-template.2.diff. I see that you changed the way that the functions are used in the tests, which is a good start, but I'll want to have a closer look to make sure that we're properly converting deprecated arguments. This might mean one or two tests that pass the deprecated arguments (with @expectedDeprecated) that then check things like pagination, etc on the results.

[boonebgorges]

In 12692:

Convert BP_Core_Members_Template to accept array of arguments.

This changeset also eliminates the use of extract() in
BP_Core_Members_Template::__construct().

Props Mamaduka.

See #3797, #7999.

[boonebgorges]

In 12693:

Add user_ids parameter to bp_has_members() and related functions.

Props Mamaduka.

Fixes #7999.