Opened 6 years ago
Closed 4 years ago
#7999 closed enhancement (fixed)
Support 'user_ids' argument in 'bp_has_members()`
Reported by: | Mamaduka | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 7.0.0 | Priority: | normal |
Severity: | normal | Version: | 1.7 |
Component: | Members | Keywords: | |
Cc: |
Description
This task requires BP_Core_Members_Template::construct()
refactoring to use array-style arguments. Patch is provided in #3797.
Changes will also affect following classes/functions:
BP_Core_Members_Template
bp_core_get_users()
Attachments (1)
Change History (8)
#2
follow-up:
↓ 3
@
6 years ago
- Milestone changed from 4.0 to Up Next
Oh, I see now that we have to change the function signature of BP_Core_Members_Template
first. This is more work that should be supported by tests. Let's do it next.
#3
in reply to:
↑ 2
@
6 years ago
Replying to boonebgorges:
Oh, I see now that we have to change the function signature of
BP_Core_Members_Template
first. This is more work that should be supported by tests. Let's do it next.
Thanks for Boone.
Should I add unit test for user_ids
argument?
#4
@
6 years ago
Thanks, George! I'm more concerned about having tests for the changes in https://buddypress.trac.wordpress.org/attachment/ticket/3797/3797.core-members-template.2.diff. I see that you changed the way that the functions are used in the tests, which is a good start, but I'll want to have a closer look to make sure that we're properly converting deprecated arguments. This might mean one or two tests that pass the deprecated arguments (with @expectedDeprecated
) that then check things like pagination, etc on the results.
This looks like a good and easy improvement.