Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #7996, comment 1


Ignore:
Timestamp:
11/04/2018 02:56:43 PM (7 years ago)
Author:
DJPaul
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7996, comment 1

    initial v1  
    88
    99Swapping `home_url` with `bp_get_root_domain` is a good idea.
    10 I'm less convinced about adding a `BP_Email` class method for the `email.preheader` part as that only sets an (optional) template token. Given this is single-use, I don't immediately see a good reason why it should be a global function. I think we would be fine to just wrap that filter call in `switch_to_blog_` etc.
     10
     11I'm less convinced about adding a `BP_Email` class method for the `email.preheader` part, as this code only sets an (optional) templating token, and I don't believe that fits into the purpose of what the `BP_Email` class represents. Given it's single-use, I don't immediately see a good reason why it should be a global function either. I think we would be fine to just wrap that filter call in `switch_to_blog_` etc.
    1112
    1213
    13