Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#7973 closed defect (bug) (fixed)

Nouveau: Faulty HTML after submitting registration form

Reported by: suvikki's profile suvikki Owned by: r-a-y's profile r-a-y
Milestone: 3.3.0 Priority: normal
Severity: normal Version: 3.0.0
Component: Templates Keywords: commit
Cc:

Description

After I submit the registration form, BuddyPress creates invalid HTML code that breaks the layout of the site. Here's the code:

<form action="" name="signup_form" id="signup-form" class="standard-form signup-form clearfix" method="post" enctype="multipart/form-data">

			<div class="layout-wrap">

		 </form>

This is what the html validator at W3 says:
End tag form seen, but there were open elements.

and also:
Unclosed element div.

Attachments (3)

7973.01.patch (1.4 KB) - added by r-a-y 6 years ago.
7973.02.patch (728 bytes) - added by r-a-y 6 years ago.
register-custom-step.png (24.5 KB) - added by r-a-y 6 years ago.

Download all attachments as: .zip

Change History (12)

@r-a-y
6 years ago

#1 @r-a-y
6 years ago

  • Component changed from Core to Templates
  • Keywords reporter-feedback added
  • Summary changed from Faulty HTML after submitting registration form to Nouveau: Faulty HTML after submitting registration form
  • Version set to 3.0.0

@suvikki - Thanks for the report. Can you try 01.patch and see if that fixes the problem?

Version 0, edited 6 years ago by r-a-y (next)

@r-a-y
6 years ago

#2 @johnjamesjacoby
6 years ago

Second patch looks good to me and fixes the issue as reported.

#3 @DJPaul
6 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.3.0

#4 @DJPaul
6 years ago

Please commit @r-a-y

#5 @r-a-y
6 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 12251:

Nouveau: Fix HTML layout after submitting members registration form.

Props suvikki.

Fixes #7973 (3.0 branch)

#6 @r-a-y
6 years ago

In 12252:

Nouveau: Fix HTML layout after submitting members registration form.

Props suvikki.

Fixes #7973 (trunk)

#7 @r-a-y
6 years ago

  • Keywords reporter-feedback removed

After 02.patch was applied, this had the effect of adding a custom step on the same row as the "Account Details" and "Profile Details" sections.

Looks like the bp_nouveau_signup_hook( 'custom', 'steps' ) call has to go after the .layout-wrap container.

Will commit this now.

#8 @r-a-y
6 years ago

In 12253:

Nouveau: Move signup custom step hook after .layout-wrap container.

r12251 mistakenly moved the signup custom step hook inside the
.layout-wrap container.

See #7973 (3.0 branch).

#9 @r-a-y
6 years ago

In 12254:

Nouveau: Move signup custom step hook after .layout-wrap container.

r12252 mistakenly moved the signup custom step hook inside the
.layout-wrap container.

See #7973 (trunk).

Note: See TracTickets for help on using tickets.